From:   Song Liu <songliubraving@fb.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Song Liu <song@kernel.org>, bpf <bpf@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "Alexei Starovoitov" <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "Andrii Nakryiko" <andrii@kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v2 bpf-next 5/7] x86/alternative: introduce text_poke_jit
Thread-Topic: [PATCH v2 bpf-next 5/7] x86/alternative: introduce text_poke_jit
Thread-Index: AQHX8Xk068zNrl6+4Em/+GWBLWr3MKwzRj6AgAJAa4A=
Date:   Thu, 16 Dec 2021 19:40:40 +0000
Message-ID: <C82FEB90-B8F3-4869-B905-8940DEBD6889@fb.com>
References: <20211215060102.3793196-1-song@kernel.org>
 <20211215060102.3793196-6-song@kernel.org>
 <Ybmyr3GB5+nZbso2@hirez.programming.kicks-ass.net>
In-Reply-To: <Ybmyr3GB5+nZbso2@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LXq7rEHuoydh+0lsOki+xJ19DHapBR41JBVuwj9S8woKFz3z4fw7Zm8YK3Ux?=
 =?us-ascii?Q?veUO1Q5pdFLs8xiUDGWUqH+5kv26iTSrGkU0iBNMi6AAUcoanbTLhw1S7uuD?=
 =?us-ascii?Q?Ho4FGGl1tA8eKZnUP8cX5Fl08L7h3NW4M0ouvlu6iPi4lTRfdY0+GlzJhxWi?=
 =?us-ascii?Q?lKCtaNtl4ZeCguhHVHrBzAt8k+P1LoBcxdEupIQtQ8yAxf3ATNzQP474W86F?=
 =?us-ascii?Q?DQRgOqJqmrTVOGu6LyhOlrQSJQ18fkaa1ca+uwgZ8bYE1Q4V4KYZNOqxpj7G?=
 =?us-ascii?Q?ADr9EyaxfDXmxSEu/cu6i40B9AG/C2WJHfKk2rLo/NeWfEZ6gIYWmk5YdZ3T?=
 =?us-ascii?Q?D9+1FgWwN/WeTBUABMNo4hjwapRBUSH5CrLAbkqh+PMQ8gXwI5wT3aYOTI+z?=
 =?us-ascii?Q?JhLPfDXAnvvJjmnLcMjamwywUTpDwmMxCXNmdo19wDUWA/vdXALGhn8iI5OK?=
 =?us-ascii?Q?E2LCvMyftLjX/wP/eIdp0zztVwzjJXKh0xt07PZWfhdUxWdMpr9qd/Z5VhzI?=
 =?us-ascii?Q?uYp0osoEGdq1Dl4wVLU1CBgtOQKe3wxqKWhP8cUex3NHigDvz0VqsSaC0x4R?=
 =?us-ascii?Q?niWlRn/q3oiDtDJlrZNlMOMh/RG4VJ9a6QjYYRSfT5+8wDoPMxLCdEMiAAqg?=
 =?us-ascii?Q?MSFfDCWWtocY83QHEpax0E+HnKIsfIq20KEyv/BxMhhVJAfDU0I/WILFfv5N?=
 =?us-ascii?Q?TNAMW+SqsW5T5Dmu4gi8hMX3G4+BVpEIgJ72uLhxhKknDs6YYtSbRpaSleG1?=
 =?us-ascii?Q?OpzD7w6NW8UcgquT5I2/jEAuIYk/Rn6WCjD1roW5Wc7AnWU6E5fhZznc+ydt?=
 =?us-ascii?Q?Hf5AKU/RUaeGQ8Fet+0d5NSmmsV6L5wXsjoA5jDBeimjCq8Y7PZ+e4tp1ddF?=
 =?us-ascii?Q?MAuQeOfVclb1KJxGqfKSqFLQhrixB34Rrn0atnISbeFGrooF32Y31TULHjG+?=
 =?us-ascii?Q?2V60c1af0hq9goRHSIT570hWmgpExztUeDLkGFs/P1+MzaoCYKjPkaKu818c?=
 =?us-ascii?Q?YdGWJHSQJlx5VYJeKb7QkR9yq32WvAL9C0rsfAw2yheY8ruYJbqxpzLTPtpp?=
 =?us-ascii?Q?5VudwYvyimGva3+PfM+LojQ8eFpOeMG5YIdoXg9y2OMdhgm1YYrH+8ZF33B9?=
 =?us-ascii?Q?Q8yAFgGl496I34YPd2Wh51PdK0j8uOI2CIGlHOEc71MJO2ztkLbgSUTWDOL7?=
 =?us-ascii?Q?W5WxtlAeElTBl2fl87RhtqXncp7/1zGVUkUfnCNXTdRXPvXGJ6LVVZ8MxFRV?=
 =?us-ascii?Q?orr+q6K53z5b2EpjAWM2kaabpDmBA2+pnJON8DBaytpwhDieFHzfpGnGLF7t?=
 =?us-ascii?Q?WNcPfZhcFyzK6dMMnlwZeaoLDYZiB1LV/3QGvdDXuVvy4gZMSTbzpYc6zMfN?=
 =?us-ascii?Q?SVj2E5sfBd39OY4muE94Uczz33PEiCjIYmFX17uKHMuVm9WROrFrHMkS8mUS?=
 =?us-ascii?Q?ukGv9J+es+F2QQKndIPMZWwbOONDajC0HpQIK689gRizlRqsBGpwBaFQB1db?=
 =?us-ascii?Q?hudoZ2YoSvBqwDfToa1sjvGOY2ORMbwUEAxgSwkBKWF/w+kFGBhc/6uBw+2D?=
 =?us-ascii?Q?cRBBRgjrswiCnrDtNkZfDqGQbMrrXTIu3AoOgGmsLOYDfGKGtja1+pIvlm74?=
 =?us-ascii?Q?e5uQc7BIHvTmptuV2SlUsN4M1m6JCkPOFP0a0SlvGXITctJZVtcRbEJQcCUO?=
 =?us-ascii?Q?Ywmg9Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FFB8D36894F2D24686B6CED5FD605564@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f7e2ddc-9fb9-461e-fcb6-08d9c0cbf105
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2021 19:40:40.2538
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AjRgNd2Og6NSKavbWmGf/xNyHniFoRzuim7O+PeIPhVt6PHuDtPPLvuo2Fiqts9kA+G/RDF/EI+HGOAlUqBD3Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR15MB5281
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: qOHWTRHqOJl14r-ht27h8NkcY15Lq-hj
X-Proofpoint-ORIG-GUID: qOHWTRHqOJl14r-ht27h8NkcY15Lq-hj
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-16_07,2021-12-16_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 spamscore=0
 mlxlogscore=764 impostorscore=0 malwarescore=0 lowpriorityscore=0
 suspectscore=0 phishscore=0 mlxscore=0 priorityscore=1501 adultscore=0
 bulkscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112160107
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Dec 15, 2021, at 1:17 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> 
> On Tue, Dec 14, 2021 at 10:01:00PM -0800, Song Liu wrote:
>> This will be used by BPF jit compiler to dump JITed binary to a RWX huge
> 
> OK, I read the actually allocator you use and the relevant code for this
> patch and the above is a typo, you meant: RX. Those pages are most
> definitely not writable.

Yeah, it was a typo. I meant to say ROX. 

Thanks,
Song
> 
> 
>> +void *text_poke_jit(void *addr, const void *opcode, size_t len)
>> +{
>> +	unsigned long start = (unsigned long)addr;
>> +	size_t patched = 0;
>> +
>> +	if (WARN_ON_ONCE(core_kernel_text(start)))
>> +		return NULL;
>> +
>> +	while (patched < len) {
>> +		unsigned long ptr = start + patched;
>> +		size_t s;
>> +
>> +		s = min_t(size_t, PAGE_SIZE * 2 - offset_in_page(ptr), len - patched);
> 
> Cute, should work.
> 
>> +
>> +		__text_poke((void *)ptr, opcode + patched, s);
>> +		patched += s;
>> +	}
>> +	return addr;
>> +}