Date: Thu, 25 Jan 2007 18:47:26 +0100
Message-ID: <s5h7ivbuhg1.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: xiphmont@xiph.org
Cc: "Pierre Ossman" <drzeus@drzeus.cx>, fedora-desktop-list@redhat.com,
       alsa-devel@alsa-project.org, jrb@redhat.com, "Greg KH" <greg@kroah.com>,
       linux-kernel@vger.kernel.org, mclasen@redhat.com,
       "Lennart Poettering" <lennart@poettering.net>, perex@suse.cz
Subject: Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks
In-Reply-To: <806dafc20701250930n185e9773i64bbd2d845c836be@mail.gmail.com>
References: <806dafc20701241750t53b86babn36831cadc7dfa76c@mail.gmail.com>
	<20070125042616.GA21813@kroah.com>
	<806dafc20701250611u9935049ja8f88deb2aac4d40@mail.gmail.com>
	<45B8C9A3.6060107@drzeus.cx>
	<806dafc20701250736yc5c3048u14ec98e9b6b92574@mail.gmail.com>
	<45B8CF7E.2040908@drzeus.cx>
	<806dafc20701250757n3dcb38b7ma5f8423ab3de9850@mail.gmail.com>
	<s5hfy9zujvr.wl%tiwai@suse.de>
	<806dafc20701250903p6b67d176wf00dd2a9d92d899f@mail.gmail.com>
	<806dafc20701250930n185e9773i64bbd2d845c836be@mail.gmail.com>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27)
 (fiddleheads) (+CVS-20060704) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1239
Lines: 31

At Thu, 25 Jan 2007 12:30:44 -0500,
xiphmont@xiph.org wrote:
> 
> > I'm working on this now and will doublecheck just in case my test was
> > flawed first time.
> 
> Doublechecking indicates my initial test was wrong somehow; both
> card->dev->parent and card->parent passed as arg 2 to the
> device_create call in snd_register_device result in correct device
> symlinks. Are these two actually semantically different?  I'm just
> curious.

If card->dev is created, they should be identical.
But, again, card->dev should be NULL on the older systems.

> The call to device_create in cound_core.c:sound_insert_unit also needs
> to be modified in order for the device symlinks in the other unit
> types to be correct.  Again, modifying the 'dev' argument to
> '(dev?dev->parent:NULL)' appears to fix the problem.  Is that
> correct/appropriate there?

Your change breaks the expected heavior if CONFIG_SYSFS_DEPRECATED is
enabled.  Then devices won't belong to card* objects any more...


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/