Date:   Thu, 16 Dec 2021 14:20:21 -0600
From:   Venu Busireddy <venu.busireddy@oracle.com>
To:     Brijesh Singh <brijesh.singh@amd.com>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Borislav Petkov <bp@alien8.de>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v8 07/40] x86/sev: Add a helper for the PVALIDATE
 instruction
Message-ID: <YbufhatJNvJEl6GK@dt>
References: <20211210154332.11526-1-brijesh.singh@amd.com>
 <20211210154332.11526-8-brijesh.singh@amd.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211210154332.11526-8-brijesh.singh@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnVUWWFBMndOend0ajU1WVh0MjJSMFZ5c0pDdFdwek5LazRpdWhJME1hUE85?=
 =?utf-8?B?NDBrY25pMjRTdXRpR2NhYU9EYW5pQmZYSjBlTG1EaUNrQUp3Y1hKODBkd0Rr?=
 =?utf-8?B?bCszUktCL1orRGp6SGU5bm5QTFpab1NoUVhhWkkyL21EMm9XYUdIdTErVWx5?=
 =?utf-8?B?eW1TRjBTVE91OFptbkpIL2RWUDNmOU4zckVlVm9Mcjg1Y3Vtd0p1UForQ2kr?=
 =?utf-8?B?Wk5rWFZ3bmEyd1UrT2F4L3VQem5oSEpLSGc0Q2Q5dXo0MWZZSzlaREFCVjln?=
 =?utf-8?B?U2oxUm9TYXd5VlZ1cTR1NDRmVkxNNzN1QVJON0l4aER5NUtBTitCVkQydzl3?=
 =?utf-8?B?WFFYQ2l2SXdoV0dhdUhOQ2JwdnlHUVpyQjZOdDk2Q1VLUWFMS1UwTzB3ZFAv?=
 =?utf-8?B?UzQxQytOTzZScm1uSDNOSW1JdTZQSW5iVkJ2RktnL21tWi9BRXYxQlQ2NXlY?=
 =?utf-8?B?TU4wYmU1MDVRNU5pcWpnTzRsbENmSWQvcXE1YktseGFzZms0WTV3MWZ5SnND?=
 =?utf-8?B?eld1cHZxYWlGRUZOaC96b1lqVGVnbjNtb2ZwbWtFa01tK0lwTU9jT0lpQWU0?=
 =?utf-8?B?S0x2OTZCbkJHWVVBZDJkU3ZTWmVXSFJKYTJLMlVlVzk4dW5QeVlBMjZGcUYy?=
 =?utf-8?B?eVpTTHVSVjNVSDVLVTdOVTZhTk8wZHVHSm80WFJHd3REOFI4dVlzbjhGZzdL?=
 =?utf-8?B?U0NrZG9ZUzBOTmwwc2tzRzlHNS9Ldk83NjR4SytOWFdtbzVVUzFiYi80RktI?=
 =?utf-8?B?ZzB3U2V2d1FTdVlOZUhCR2xudmprVkRPOHJaNUtDTmlrMFcyNFQvMXA1K05z?=
 =?utf-8?B?Si9zVjRRV0tpcGVlcEJlUXRYUTlSdzZJcCt6REpsL3dnb0lCdVQ2RkxQMUI3?=
 =?utf-8?B?VU1QZkxwUWtsbkV3OHdza0tpVXJYbU1NeGhCZWVSMlBEdjhBY2xTdTZFdHpu?=
 =?utf-8?B?a2hsWWk2Y1JLUFJKdkV4WFJ5OUFzUUlxRkNYN2Ftc2FhYmhSVzMrbGdhWXlS?=
 =?utf-8?B?MnM0MWhyUzFUdmJiQnYwOHNabm5XaURvcXUveUpRbG9PYTRHTXpra1JMT0VX?=
 =?utf-8?B?QnUvcElGSjNhZ2tNSFRFUzZ5QlhmTTNRbFhMajhtZ0hVZzZjSVMrQXJlbkty?=
 =?utf-8?B?bzZmZXRLOWU1a0REbElQTlp1SW1takswayt5T0kzeWFsTXgxYlB1Q05vTUEx?=
 =?utf-8?B?Kys1TEJsVllFS2V0TFRGdnJxaUtPeWxjQ3hwdmxCYlpDRHFtV2lHWHpSK1Zw?=
 =?utf-8?B?bjhUb2NvWDlXYzdpRWg3MzRwQ1RmNlpCRDJHS0pUZDk5RDJjaCtEbGVtdDNw?=
 =?utf-8?B?aGF6ZXEva2VFazFlZ1R1alhLL3ZjNTF2NTFCWUJzb3g4RmxvZHp1R1duMjA4?=
 =?utf-8?B?MmJlbDhPUUN4QkllSzB2ZlZqclZPQlFBcGJ5dXo5aERuQTJvcnpzZ0JuSFBw?=
 =?utf-8?B?QndkczNaQzhSTDFsbFU3dFhRTVpWeDNBbHNpd3RaZVNtblh1WjBGa0ZHVGZt?=
 =?utf-8?B?TUtRcFhvWEdMTG9POTA5clBmNkk3T2ZmUmkvL2h5dVZCMWlnbTZQNGEyc3FV?=
 =?utf-8?B?c0dJRkRnK1VMQzVjam9GRUVNWjBSbi9Bb2pFSEJ1V0gvV2hDSDk4LzhZUzR2?=
 =?utf-8?B?d1B1amNxZThkbWNHWjFhcE96bjkrRjJUMmlOWkVtdGNOSVdHRFh5dGVxVWc5?=
 =?utf-8?B?UjliVEYvVnJMeDRPdGRVa2NHdlE4QXorbUlkZTBtbE1Rd29aelZMRHNEcDNM?=
 =?utf-8?B?aXVFSno5bWtLZ1NaUlA3dzQ5U3ZhNXRFWEVIYWhnVXVMRG9PcEdweEZFOEZL?=
 =?utf-8?B?SzM3Smo1aU5JaTY1S0lHWkR1MFc1eFU2K2R3eHBzZkYrVzdSUUhyVTQ2eDdN?=
 =?utf-8?B?ZG9EVk92UHlKeWpYNnpha1pPNm9PK2U3cnJ3ckVQNnY2VDlWQ2UxVmd0Znhi?=
 =?utf-8?B?TzJtbzNrWWVybDNuRFhpMG16aEVLbzFVNzdoRFVaY3NVVm1XT05PanNYZHVk?=
 =?utf-8?B?VmdXNWp0Qjh6aU83MGY2MnRDdHNtOTdCY1FpL3c4cmFmQmx2a0NDYmpxcVI1?=
 =?utf-8?B?MGxwbXBEQVpoMVJVQVpnY1AzVzZqL1E0S2plWWRGZGp5MXFQR0EwdzBrUXRh?=
 =?utf-8?B?T3FFQWNwS0VuUzZJd3p6d3RnR0REWFkxRkNtQWs0TWhQb1lOZTVHRHJkeUNT?=
 =?utf-8?B?MmlPck9kM2RVZmloU2FHMG1qcHNlZ2VGb2VMNTJuay9NY2tjVWJ4NXpPMHZi?=
 =?utf-8?B?OUdoR0VCKzFOT25BY0NHVGJsWUl3PT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fdb39ccd-65a3-409e-4f8e-08d9c0d181af
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2576.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 20:20:30.8352
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0SwVn03P/wtH2bAaEb9U0p8Z4+9zXAzMqrZ4WfZWyPuO1XiskVq8m9m4FNugClfdyh2r7TlM+F1UWRJq3zVqXM1Yop3M9BJhwRbUGfTNwBE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4683
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10200 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0
 malwarescore=0 bulkscore=0 spamscore=0 mlxlogscore=999 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112160110
X-Proofpoint-GUID: Ktq0AqsY_HjRvqisu8n0DTqByEKo6hyy
X-Proofpoint-ORIG-GUID: Ktq0AqsY_HjRvqisu8n0DTqByEKo6hyy
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021-12-10 09:42:59 -0600, Brijesh Singh wrote:
> An SNP-active guest uses the PVALIDATE instruction to validate or
> rescind the validation of a guest page’s RMP entry. Upon completion,
> a return code is stored in EAX and rFLAGS bits are set based on the
> return code. If the instruction completed successfully, the CF
> indicates if the content of the RMP were changed or not.
> 
> See AMD APM Volume 3 for additional details.
> 
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>

Reviewed-by: Venu Busireddy <venu.busireddy@oracle.com>