MIME-Version: 1.0
References: <20211215224832.1985402-1-robh@kernel.org> <Ybp8QMyoW+MxTgmJ@piout.net>
In-Reply-To: <Ybp8QMyoW+MxTgmJ@piout.net>
From:   Rob Herring <robh@kernel.org>
Date:   Thu, 16 Dec 2021 15:22:35 -0600
Message-ID: <CAL_Jsq+QbqH3tsZPjJb-WUObpXos9TQ2b_aB5ih_KSPVQcYLLA@mail.gmail.com>
Subject: Re: [PATCH] serial: atmel: Use platform_get_irq() to get the interrupt
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     Richard Genoud <richard.genoud@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Ludovic Desroches <ludovic.desroches@microchip.com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Dec 15, 2021 at 5:37 PM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
>
> Hello Rob,
>
> On 15/12/2021 16:48:31-0600, Rob Herring wrote:
> > Accessing platform device resources directly has long been deprecated for
> > DT as IRQ resources may not be available at device creation time. Drivers
> > continuing to use static IRQ resources is blocking removing the static setup
> > from the DT core code.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> >  drivers/tty/serial/atmel_serial.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> > index 2c99a47a2535..9e57bfe523cf 100644
> > --- a/drivers/tty/serial/atmel_serial.c
> > +++ b/drivers/tty/serial/atmel_serial.c
> > @@ -2479,7 +2479,7 @@ static int atmel_init_port(struct atmel_uart_port *atmel_port,
> >       port->fifosize          = 1;
> >       port->dev               = &pdev->dev;
> >       port->mapbase           = mpdev->resource[0].start;
>
> Shouldn't you fix that one at the same time?

Sure, I'll make a 2nd patch as it has little to do with $subject.

>
> > -     port->irq               = mpdev->resource[1].start;
> > +     port->irq               = platform_get_irq(mpdev, 0);
> >       port->rs485_config      = atmel_config_rs485;
> >       port->iso7816_config    = atmel_config_iso7816;
> >       port->membase           = NULL;
> > --
> > 2.32.0
> >
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com