Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965557AbXAYSXa (ORCPT ); Thu, 25 Jan 2007 13:23:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965559AbXAYSXa (ORCPT ); Thu, 25 Jan 2007 13:23:30 -0500 Received: from ns2.suse.de ([195.135.220.15]:35424 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965557AbXAYSX3 (ORCPT ); Thu, 25 Jan 2007 13:23:29 -0500 Date: Thu, 25 Jan 2007 19:23:19 +0100 Message-ID: From: Takashi Iwai To: xiphmont@xiph.org Cc: "Pierre Ossman" , fedora-desktop-list@redhat.com, alsa-devel@alsa-project.org, jrb@redhat.com, "Greg KH" , linux-kernel@vger.kernel.org, mclasen@redhat.com, "Lennart Poettering" , perex@suse.cz Subject: Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks In-Reply-To: <806dafc20701251007n69bc9b3cse023b51369501d42@mail.gmail.com> References: <806dafc20701241750t53b86babn36831cadc7dfa76c@mail.gmail.com> <806dafc20701250611u9935049ja8f88deb2aac4d40@mail.gmail.com> <45B8C9A3.6060107@drzeus.cx> <806dafc20701250736yc5c3048u14ec98e9b6b92574@mail.gmail.com> <45B8CF7E.2040908@drzeus.cx> <806dafc20701250757n3dcb38b7ma5f8423ab3de9850@mail.gmail.com> <806dafc20701250903p6b67d176wf00dd2a9d92d899f@mail.gmail.com> <806dafc20701250930n185e9773i64bbd2d845c836be@mail.gmail.com> <806dafc20701251007n69bc9b3cse023b51369501d42@mail.gmail.com> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27) (fiddleheads) (+CVS-20060704) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2267 Lines: 56 At Thu, 25 Jan 2007 13:07:04 -0500, xiphmont@xiph.org wrote: > > On 1/25/07, Takashi Iwai wrote: > > At Thu, 25 Jan 2007 12:30:44 -0500, > > xiphmont@xiph.org wrote: > > > > > > > I'm working on this now and will doublecheck just in case my test was > > > > flawed first time. > > > > > > Doublechecking indicates my initial test was wrong somehow; both > > > card->dev->parent and card->parent passed as arg 2 to the > > > device_create call in snd_register_device result in correct device > > > symlinks. Are these two actually semantically different? I'm just > > > curious. > > > > If card->dev is created, they should be identical. > > But, again, card->dev should be NULL on the older systems. > > > > > The call to device_create in cound_core.c:sound_insert_unit also needs > > > to be modified in order for the device symlinks in the other unit > > > types to be correct. Again, modifying the 'dev' argument to > > > '(dev?dev->parent:NULL)' appears to fix the problem. Is that > > > correct/appropriate there? > > > > Your change breaks the expected heavior if CONFIG_SYSFS_DEPRECATED is > > enabled. Then devices won't belong to card* objects any more... > > FWIW, CONFIG_SYSFS_DEPRECATED is enabled on all my machines-- it's > exactly that behavior that is wrong in 2.6.20-rc5 and that I'm trying > to fix (and testing against here/now). Err, replace /enabled/disabled/ in my reply above. The problem with your patch is that it breaks the structure newly introduced. In the new tree, card* contains the whole belonging devices, and each device points to the one in the card object. Passing dev->parent there cuts the relation between the card object and each device. That's why my patch rules out setting card->dev with ifdef CONFIG_SYSFS_DEPRECATED. As fallback, it takes the parent device to build the old style tree. > Having just checked a 2.6.18 machine, none of the device symlinks > point to card* objects; thay all point to /sys/devices/.... Yes, it's a new stuff. Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/