Date: Thu, 25 Jan 2007 19:38:48 +0100
Message-ID: <s5h1wljuf2f.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: xiphmont@xiph.org
Cc: "Pierre Ossman" <drzeus@drzeus.cx>, fedora-desktop-list@redhat.com,
       alsa-devel@alsa-project.org, jrb@redhat.com, "Greg KH" <greg@kroah.com>,
       linux-kernel@vger.kernel.org, mclasen@redhat.com,
       "Lennart Poettering" <lennart@poettering.net>, perex@suse.cz
Subject: Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks
In-Reply-To: <806dafc20701251034l59fc5be7ta881606046eb819a@mail.gmail.com>
References: <806dafc20701241750t53b86babn36831cadc7dfa76c@mail.gmail.com>
	<806dafc20701250736yc5c3048u14ec98e9b6b92574@mail.gmail.com>
	<45B8CF7E.2040908@drzeus.cx>
	<806dafc20701250757n3dcb38b7ma5f8423ab3de9850@mail.gmail.com>
	<s5hfy9zujvr.wl%tiwai@suse.de>
	<806dafc20701250903p6b67d176wf00dd2a9d92d899f@mail.gmail.com>
	<806dafc20701250930n185e9773i64bbd2d845c836be@mail.gmail.com>
	<s5h7ivbuhg1.wl%tiwai@suse.de>
	<806dafc20701251007n69bc9b3cse023b51369501d42@mail.gmail.com>
	<s5h4pqfufs8.wl%tiwai@suse.de>
	<806dafc20701251034l59fc5be7ta881606046eb819a@mail.gmail.com>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27)
 (fiddleheads) (+CVS-20060704) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1882
Lines: 48

At Thu, 25 Jan 2007 13:34:19 -0500,
xiphmont@xiph.org wrote:
> 
> On 1/25/07, Takashi Iwai <tiwai@suse.de> wrote:
> 
> > The problem with your patch is that it breaks the structure newly
> > introduced.  In the new tree, card* contains the whole belonging
> > devices, and each device points to the one in the card object.
> > Passing dev->parent there cuts the relation between the card object
> > and each device.
> >
> > That's why my patch rules out setting card->dev with ifdef
> > CONFIG_SYSFS_DEPRECATED.  As fallback, it takes the parent device to
> > build the old style tree.
> >
> > > Having just checked a 2.6.18 machine, none of the device symlinks
> > > point to card* objects; thay all point to /sys/devices/....
> >
> > Yes, it's a new stuff.
> 
> [This does beg the question: Does the benefit of this complete
> restructuring in a subminor release of an allegedly stable kernel
> outweigh the fact that it breaks all audio for any user running a
> gnome desktop?]

Well, that's not me who introduced that ;)

> OK, so my patch should be passing card->parent or dev->parent only in
> the case that CONFIG_SYSFS_DEPRECATED is set, and leaving the call the
> way it was previously in the case CONFIG_SYSFS_DEPRECATED is not set.
> Essentially, ifdef/else both cases?

Also, avoid creating card* instance.  It makes no sense in that case.
(So... what's wrong with my patch?)

> Is this also going to have to be the case for every other class type
> that converts from class_device_create to device_create?

I don't think so.  The case of sound class is more complicated, a
combination of API change and a new tree.


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/