MIME-Version: 1.0
References: <20211215030420.72324-1-xiujianfeng@huawei.com>
 <20211215220004.GA21862@embeddedor> <ade6655d-a62e-1d57-d623-4bfc93ebbc57@huawei.com>
In-Reply-To: <ade6655d-a62e-1d57-d623-4bfc93ebbc57@huawei.com>
From:   Paul Moore <paul@paul-moore.com>
Date:   Thu, 16 Dec 2021 17:42:44 -0500
Message-ID: <CAHC9VhRCMp=E15FKVVSmkrat_u_WqWY6WE=Evsj=Ar-hHm3y3Q@mail.gmail.com>
Subject: Re: [PATCH -next, v2] audit: use struct_size() helper in kmalloc()
To:     xiujianfeng <xiujianfeng@huawei.com>
Cc:     "Gustavo A. R. Silva" <gustavoars@kernel.org>, eparis@redhat.com,
        keescook@chromium.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Dec 15, 2021 at 9:05 PM xiujianfeng <xiujianfeng@huawei.com> wrote:
> =E5=9C=A8 2021/12/16 6:00, Gustavo A. R. Silva =E5=86=99=E9=81=93:
> > On Wed, Dec 15, 2021 at 11:04:20AM +0800, Xiu Jianfeng wrote:
> >> Make use of struct_size() helper instead of an open-coded calculation.
> > I think you should also mention the flexible array transformation in
> > struct audit_rule_data.
>
> thanks,  and due to the previous patch has been merged into linux-next,
> a diff patch about struct_size() and
>
> a seperate patch about flexible array will be send.

Please make sure to send it to the audit mailing list as well.  I
don't like merging patches that haven't been sent to the mailing list,
it's a bad practice IMO.

--=20
paul moore
www.paul-moore.com