Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAD02C433F5 for ; Thu, 16 Dec 2021 23:04:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236953AbhLPXEv (ORCPT ); Thu, 16 Dec 2021 18:04:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236531AbhLPXEu (ORCPT ); Thu, 16 Dec 2021 18:04:50 -0500 Received: from mail-vk1-xa31.google.com (mail-vk1-xa31.google.com [IPv6:2607:f8b0:4864:20::a31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA275C06173F for ; Thu, 16 Dec 2021 15:04:50 -0800 (PST) Received: by mail-vk1-xa31.google.com with SMTP id s144so395905vkb.8 for ; Thu, 16 Dec 2021 15:04:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=62Uz9CtJjse1+mi3hhz9xxMLxgwHg1IYiyqR2g0WvAA=; b=oPpXX7fgyAeN9ysmwYzwz32+GFqY/Iii0AaKKKG+n0F9HkkkErU2yygWDqsaUCYycZ PcNZbJ12SXX3b3Ku2pVI0MO8fMqE5E7ZnTAgG8m/oSqCbVuVnCwPSgHfCP6PtW8k3QeN m640crZ1dsbJ0nS1wTE0RVThYDu93z94C8BXBYq4A1y+1pujPBnx/afeq5nwSzcA1aMU BbuSP5Mr1hR29FbnlS+jkOci7VnaFa2W/yi17LxpDiKDriiemUVO/gNl2Bc4Ewf8hLog NqD1KMoJHN4h8hcOO/JPmJzzFbg6N1ey9V8xhj7D87bcKMvi/NEsMJOKW7LmZbiMbR32 8VHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=62Uz9CtJjse1+mi3hhz9xxMLxgwHg1IYiyqR2g0WvAA=; b=Prq6GmTXXusR4rx+wwd7SZyCQIzbX/MYEWG7xT5OYNWVUclFFhefbJ+5DDsyY6XEX9 Ct/Nr57HxZhTXQ+yKyxdBGV11zLHh06zexcDaji0s12i2hWfLu6+Vuqg7JkQBraL7WTk t+e498+60s6wqc6ddoBQj5nY4UwKGck4JmeWACQg3g9AcJesljoR8ECvrMJgAd+llDkO 1K5pHz/Nkolk7YB/rQVDxRlTzGiCFJiQfzKWmb+NM8T1ciD3a5/9bHdGaYOS6eHVqZID t97q78Eiunf1dQXqsF9Db7cKWaDfp05VU5kNQo6Vz1YZhIfoZGqqYX1fPCHt0UQZGXvx Spzw== X-Gm-Message-State: AOAM532XWIVXcVfJMXvkhVlXQH+wtEKCV/kaTI00kZsZVor/x9DMPvpj yOIIqytlHOKEnC+7piuTNzRsw/vX4EqupngSJBLSig== X-Google-Smtp-Source: ABdhPJw2TfUn4th8xuwGPyMcVF2I9HdXvfjfdX6cQIhp0D9opZOAXKvCtBGcWZWf6KrSbEYAnCgWoautwgTD+eidIEM= X-Received: by 2002:a05:6122:c9b:: with SMTP id ba27mr176340vkb.14.1639695889846; Thu, 16 Dec 2021 15:04:49 -0800 (PST) MIME-Version: 1.0 References: <20211212181057.20210-1-semen.protsenko@linaro.org> In-Reply-To: From: Sam Protsenko Date: Fri, 17 Dec 2021 01:04:38 +0200 Message-ID: Subject: Re: [PATCH] i2c: exynos5: Fix getting the optional clock To: Wolfram Sang , Sam Protsenko , Krzysztof Kozlowski , Chanho Park , Jaewon Kim , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Dec 2021 at 23:22, Wolfram Sang wrote: > > On Sun, Dec 12, 2021 at 08:10:57PM +0200, Sam Protsenko wrote: > > "hsi2c_pclk" clock is optional and may not be present for some SoCs > > supported by this driver. Nevertheless, in case the clock is provided > > but some error happens during its getting, that error should be handled > > properly. Use devm_clk_get_optional() API for that. Also report possible > > errors using dev_err_probe() to handle properly -EPROBE_DEFER error (if > > clock provider is not ready by the time I2C probe function is executed). > > > > Fixes: c93ac09df2a8 ("i2c: exynos5: Add bus clock support") > > Signed-off-by: Sam Protsenko > > Applied to for-next, thanks! But I needed to fix the Fixes tag? > Ah, sorry about that! I probably looked at some other tree. Thanks for applying!