MIME-Version: 1.0
References: <20211216055958.634097-1-sharinder@google.com> <20211216055958.634097-4-sharinder@google.com>
 <CANpmjNOGaVgP25xNOSGOyjcA9Lmk4uFmU=f6RrRNJBP_CMEVrQ@mail.gmail.com>
 <87czlwcfav.fsf@meer.lwn.net> <CAHLZCaGh6Z1m50CYMae8AuY_524TzXtv-SP52FbLRj2Ks0fN1g@mail.gmail.com>
In-Reply-To: <CAHLZCaGh6Z1m50CYMae8AuY_524TzXtv-SP52FbLRj2Ks0fN1g@mail.gmail.com>
From:   Brendan Higgins <brendanhiggins@google.com>
Date:   Fri, 17 Dec 2021 00:07:15 -0500
Message-ID: <CAFd5g44f1VyJKkwzxkLxwkDQT+pB2ZBWo_g0ficNkOf_Oa1u1g@mail.gmail.com>
Subject: Re: [PATCH v4 3/7] Documentation: KUnit: Added KUnit Architecture
To:     Harinder Singh <sharinder@google.com>
Cc:     Jonathan Corbet <corbet@lwn.net>, Marco Elver <elver@google.com>,
        David Gow <davidgow@google.com>, shuah@kernel.org,
        linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Tim.Bird@sony.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Dec 16, 2021 at 11:57 PM Harinder Singh <sharinder@google.com> wrote:
>
> Hello Jonathan and Marco,
>
>
> On Fri, Dec 17, 2021 at 4:45 AM Jonathan Corbet <corbet@lwn.net> wrote:
> >
> > Marco Elver <elver@google.com> writes:
> >
> > > In response to the other email: Adding binary blobs just creates
> > > problems, for comparing different versions, and general bloating the
> > > whole repo, where better alternatives exist.
> > >
> > > I suppose an ASCII diagram is a bit primitive. :-)
> > >
> > > However, SVG files on the other hand are not binary blobs, they are
> > > text-markup based (XML), and e.g. diffing them often provides useful
> > > information about what changed. SVG also has the benefit of being
> > > vector graphics, and not being limited to one resolution.
> > >
> > > Looking at the diagram you added, I think this can easily be turned
> > > into vector graphics, and most likely will not use up 24KiB as a
> > > result.
> >
> > I agree with all of this; we shouldn't be adding binary images to the
> > docs, and we've decided at other times that SVG is generally the best
> > compromise there.
> >
> I did not realize that .SVG is in XML format and preferred over .PNG.
> Thanks for pointing this out. I replaced .SVG with .PNG.
>
> > Thanks, Marco, for pointing this out and producing an alternative.
> >
> A big thanks to Marco for creating  this .SVG file for the documentation :-)
>
> > Once this is all settled, do you want it to go through the docs tree?
> >
> Yeah! that's the plan.

Yep, please take this through the docs tree.

I will send out my Reviewed-by on the other patches shortly.