Message-ID: <f2ef853b-7ff3-4fd7-989f-032fec66945d@intel.com>
Date:   Fri, 17 Dec 2021 10:42:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.3.0
Subject: Re: [PATCH] ASoC: wm8962: potential use of error pointer
Content-Language: en-US
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, <lgirdwood@gmail.com>,
        <broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
        <kuninori.morimoto.gx@renesas.com>, <shengjiu.wang@nxp.com>,
        <daniel.baluta@nxp.com>
CC:     <patches@opensource.cirrus.com>, <alsa-devel@alsa-project.org>,
        <linux-kernel@vger.kernel.org>
References: <20211217031333.493777-1-jiasheng@iscas.ac.cn>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <20211217031333.493777-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHNTdnJ3MmlHQTZTQmMyaHhOR3pRZzkwcC84bHpDZVR3dE0zelhSbTNJZ0FJ?=
 =?utf-8?B?ZUhNMkpFZGk5YytuWUd1Y1RLWEdpWDBtSlVCQy9DTWlZbnFhc1ZVRVZtQXpk?=
 =?utf-8?B?ZFZOeEVha3FQeXAxTG5KcUxwUnE3UGxVRkxaRE5kUFF5NldyRUcydnNOZWFp?=
 =?utf-8?B?NzNEb09rWnhBVnJxbWZSQk1jRTh1Zko0aFplU3hNSk45dE9vTGN1a3NkUkRL?=
 =?utf-8?B?NURiUFhLWThBUUlEWXBIQktaWU5XbVNtVEx3YzYxTWllSFJhTTFSSXFFdFBq?=
 =?utf-8?B?UGkzNVBDbG93b0ZPTTF2dmo3MmtVZ2JBRUgxaSsyRDNQNDMxdkF5djR3NFNT?=
 =?utf-8?B?bm54MEdyQ2Z4MVhsazNUcGVqQldMc1haMVRUUHRFVzFYK0k0dmFyaGtiaUli?=
 =?utf-8?B?aTNMWUpJTlptUTJDaFlsTmZXTjByeTE0c3dyQitvVHM4bTVZeUdiZmUzTVJO?=
 =?utf-8?B?UnpRT0QwbU5UeGlBWFE1Zk9iS1oreU8waHZNK05UaE50WVIzQTJvTE9xMXNL?=
 =?utf-8?B?UFhNSmdXMENYT2JadmVob3c2TEllRzBYZFN3SEV5MEpFVXZQeXgvMjBpVTNW?=
 =?utf-8?B?LzJEc0drTHVEVFVEUldTUkNWRDZpOUw2bE5qVGhpL04vVE1DMzBNUGVHWXpS?=
 =?utf-8?B?Z2VUcHFSbWlWSTJSSndKSWVyTVJmallJSDRZeElvVFpuT1FVdGx5emROOVpR?=
 =?utf-8?B?VGt6bGZiYjhDOXlqMkxKdkVJN2RFaTJHZ0FOMk1ZZExPTmo5UUlKZXUySldY?=
 =?utf-8?B?ZHRPRjhOMzBQN3VPOG9DOXJva3JMR3NjbU5reVN4U25PME5jQnp5MXkzOTRp?=
 =?utf-8?B?OUU3RUQ2SzBweS9qN1ZTY09WdzRyL0cvQUl1YW1pcS8rS1hTdEprc1V5cENn?=
 =?utf-8?B?NjlkbzI2cEV4TU84SXlCbTdTN0o3Q2o1ZGUvVHQzSzZIbS9kbGhJQ3ZTVlh3?=
 =?utf-8?B?OC9rbzNMQURXN2JWNmV1V2pIQ254UTl6QnBiTy81dW9xZzA0N3QrVmhxZExm?=
 =?utf-8?B?c3AzbWR3NmhQR0llV0VtUkNnbkIzK2FuRU5kZW96L2R5T0JucE9FRHNyeEJK?=
 =?utf-8?B?Ty93emRzV0pUbFNtb0FRK3l6alQ1TTkremRaNDk0UHB6TnBaSVR3cE9xMXVt?=
 =?utf-8?B?TTZCSVJ6WTVkZ2JyczhkY2VtUWh6RkxqUGtkL3RJM0RRWEZvQ2xZZXRxUGZV?=
 =?utf-8?B?MW5IOExYUEdZSHNLcFloTUZGdlZBNjJqUGNYWVZRRlR2c0IvMzhuTWFZaSty?=
 =?utf-8?B?a2VuUjl3MnRTTXk1bEV2TDhldmJhbTMrenRUYk9GVDVGTm5rQVJ0NW56K3I5?=
 =?utf-8?B?Z2dESXFYMjBqSWFQc2UxNThqbFZkQlRTbFdPN25BYXBHMWY1RmJ1bXRuU0xo?=
 =?utf-8?B?bmtZRXQ1ZjZYWG1HRHZxZ2hWS1VDeGh2TDFQOVdNVnBtMWJ6NzNBUFVEUEtq?=
 =?utf-8?B?Ym1sWk5hY2dpYll2cEtBT3JRY0dpZ2xsejBoVjhrY3ZST2x6Sm4zSGNmeG93?=
 =?utf-8?B?cndFdS9sYnFadmpHSUVvVFhtV0NEVUdOVGhCR2szSkZYYXNDMUN6d2lVS3lx?=
 =?utf-8?B?V2lLYk85RDJIcWl4a0xHcmFtRnFTQjRoOHFMZTlUbnl1RjRwRDlHTS9vOWkw?=
 =?utf-8?B?eGtja05WZXRMS1pFak1YYUVrZGR1NmdRMGM4dzVZLzMyRWxiWWpxUXdOTnJl?=
 =?utf-8?B?cFg3R2dBaGl6VU1SbklubkMxQ204dzNVbTQ4RkNmUnR3eWlCaUVWV2xVOXdo?=
 =?utf-8?B?R2diUmdlK0dEVElMOHVESEVyVFVJQzdsQS9JNmM0NEROZUZVRGU3US95djZm?=
 =?utf-8?B?OWJVY0xtZEdrYndlcmREM3pzUWlqZm1LOXR1WVFvaFB4bldjOTlQRStHUmEr?=
 =?utf-8?B?c0t4dzZNQ09zNDBIMGgyRHFQVjdIakxOeDB1NWM1bGNtQVBDYXE4UjJuYno3?=
 =?utf-8?B?MEE3S1ZtNWkrOHRkOHR2L1lXM0lpRDJiWnpoaDhHdFJnS0RMRE9OakN4MVda?=
 =?utf-8?B?UlNUSS9VVkpLZDJJNXZrTXR1NTF0L2JVYlFnb2F2cEgwTGJLaWNyRmVtNHJ1?=
 =?utf-8?B?MEpBRFhMemxQWjlVZkdJQ3c4ZnQwT3k2NURuMFVwM3RwYVJ2ZkdZaVVNTWxp?=
 =?utf-8?B?K0VQeFFNczA2SnorWXhndU1jUCtoMTlLSzM5Mk5PTlVZNmJ0V1pTSzZiM1do?=
 =?utf-8?B?b2NJMFNablBCbUdFZ1BqcjhPd29HaEpucTcxUmNPOXNzVzNiSjM2Q3p1bStp?=
 =?utf-8?Q?TC3x3d1SySchV7tagAOzjkj3SWseoKxVZ4daCzUmLk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 23194668-78bf-414d-f086-08d9c14198e3
X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB4049.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 09:42:53.3365
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IcR+9Oe1+byLlpi2+cQPgxTxdeKw3LatIJTOvfCjDwkRxmbxG2IxZRH46XTOjkX+fIEU0iirTDiKlY4IjywyeCX+nC0zph/7waQZX+MT6Hk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4036
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021-12-17 4:13 AM, Jiasheng Jiang wrote:
> The return value of devm_clk_get() needs to be checked.
> To avoid use of error pointer in case of the failure of alloc.
> 
> Fixes: d74e9e7090ae ("ASoC: wm8962: Add device tree binding")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>   sound/soc/codecs/wm8962.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c
> index 34080f497584..66693bf17763 100644
> --- a/sound/soc/codecs/wm8962.c
> +++ b/sound/soc/codecs/wm8962.c
> @@ -3540,6 +3540,8 @@ static int wm8962_set_pdata_from_of(struct i2c_client *i2c,
>   		}
>   
>   	pdata->mclk = devm_clk_get(&i2c->dev, NULL);
> +	if (IS_ERR(pdata->mclk))
> +		return -ENOMEM;
>   
>   	return 0;
>   }
> 

Correct me if I'm wrong, but -ENOMEM is not the only error code that 
could get returned by clk_get() (which is internally called by 
devm_clk_get()). Is there a specific reason for ignoring the return value?


Regards,
Czarek