Message-ID: <611d4055-c50c-55c1-0e02-43ffda66dbce@canonical.com>
Date:   Fri, 17 Dec 2021 11:42:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH 1/1] riscv: default to CONFIG_RISCV_SBI_V01=n
Content-Language: en-US
To:     Jessica Clarke <jrtc27@jrtc27.com>
Cc:     Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20211216123538.175087-1-heinrich.schuchardt@canonical.com>
 <BC1B38E7-1170-4C05-948A-D18E80AC49E7@jrtc27.com>
 <fd40010f-f2ec-b32a-6850-1e054af43725@canonical.com>
 <150C4E84-2C69-45DB-AF27-1E0C223D8D7A@jrtc27.com>
From:   Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
In-Reply-To: <150C4E84-2C69-45DB-AF27-1E0C223D8D7A@jrtc27.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 12/16/21 17:51, Jessica Clarke wrote:
> On 16 Dec 2021, at 14:17, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote:
>>
>> On 12/16/21 14:49, Jessica Clarke wrote:
>>> On 16 Dec 2021, at 12:35, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote:
>>>>
>>>> The SBI 0.1 specification is obsolete. The current version is 0.3.
>>>> Hence we should not rely by default on SBI 0.1 being implemented.
>>> It’s what BBL implements, and some people are still using it,
>>> especially given early hardware shipped before OpenSBI grew in
>>> popularity.
>>> Jess
>>
>> Do you mean BBL is not developed anymore?
>>
>> Some people may still be using a 0.1 SBI. But that minority stuck on an outdated software stack does not justify defaulting to deprecated settings in future Linux releases.
> 
> BBL is still actively maintained; its most recent commit was 24 days
> ago. Also, the amount of code CONFIG_RISCV_SBI_V01 affects is tiny, so
> I see no tangible benefit from making this change, just unnecessary
> breakage of perfectly functional systems.

Only the default is changed. How could this break any existing system?
You can still compile with the deprecated setting.

I can not see why we should keep a default that will cause issues on 
systems complying to the current SBI specification.

Best regards

Heinrich