Subject: Re: [PATCH v2 0/8] Host1x context isolation support
To:     Robin Murphy <robin.murphy@arm.com>,
        Mikko Perttunen <cyndis@kapsi.fi>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        thierry.reding@gmail.com, joro@8bytes.org, will@kernel.org,
        robh+dt@kernel.org
Cc:     linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
References: <20210916143302.2024933-1-mperttunen@nvidia.com>
 <10de82cf-27a5-8890-93a5-0e58c74e5bcc@kapsi.fi>
 <a1c8c438-72e6-0938-1b05-09694983164d@arm.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <6d03afa9-f809-f32f-8baf-4348da0dc80e@nvidia.com>
Date:   Fri, 17 Dec 2021 11:16:09 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <a1c8c438-72e6-0938-1b05-09694983164d@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFN0aElMZWI3R1R2VEQ1L0lUWkVlU3RvNzdLWC9UMFhwdHd1TWNsSkU5cERy?=
 =?utf-8?B?ODFhRWpWTWpPcWVoZ2RxY1NlRWlEc0hrUThIa0tyb0UwN29ZcEF0eVJyb1FD?=
 =?utf-8?B?UUZmZ3B6bFY5aHdnMVV4S1ZXNklSdDFmL29YaUFjUVBKWlY5dlc4U2VhWDV5?=
 =?utf-8?B?b3p2UkZpdTlJblJGbGhsT0JrWGJJL3h1bk1nQ3NsVllCSTNMdzNWTFhHTUJw?=
 =?utf-8?B?TWFyeUdlM0NZb3dFQ2xXL1ZjYXJCd3NxUkdib2pJbkFpWnU1bUFlVVZrU0N2?=
 =?utf-8?B?SDZQZ3d1Si9LeThYT1NLVUxoU1VCTCsxMXdsOC9WdDRGM1hkQnM5eC9QMzdC?=
 =?utf-8?B?S2x4aWkxc1gxL2NnVE5vUjZCRkdhRkdOc1lYb1I2RCtFeXg0NTZZU1QzSW5V?=
 =?utf-8?B?b2orbW1XNVFRWHBpU2xnWmRLblA3WHMvNVRlNXM2LzZreVZDYTUxdnlob3hr?=
 =?utf-8?B?NXRnZHgwamtLRWozMkNSWFhzSHJUSTZlcnBYbVFRMG8yc1RiTzhYWTl6YTh1?=
 =?utf-8?B?OUY2eDVwVjRkWGFGNXF6M0YvR1FCMFpuUTY5RXhCTUltYkVScGtYK3ZTQkN3?=
 =?utf-8?B?NUY3RmlTUWlCNWdWZWJHclR1V0UwVXdyclpVSFpxQk9ZNm9LNXY1UHplTjds?=
 =?utf-8?B?YjZ1U0NMTGlETm1VaDFDLzlKUUZvT2dVenpjbWhtaDA5V2dKUkQ4Q0YwNUto?=
 =?utf-8?B?VmluVW1WWXgrUGlZOWQ1elkyNzMxcDBHTnkyc0lhKzdYRVRmNWlCM3M5NWFO?=
 =?utf-8?B?UDRWVEhQdnY4amFCdUUwU0c5ZnpGZ1FhbkMyVU1KU1czNjI0czE3ZlZrcEhR?=
 =?utf-8?B?a1RXZGF6akY3a2RReGwvOFRYZmg4OEpNeFNacGNEMVlXT0g0ekVXbWxlYkRj?=
 =?utf-8?B?b1RYRGpQYXdxOWtMQmtzWFlPRGJXbVhmVjMzSlVQTnBHYkY3NWFTb29La1BR?=
 =?utf-8?B?QmVxUXJpV081cVNmdVRjSk1BRFJNSGNGOURvcFhjWmZmZVVpempPQUZTWDFn?=
 =?utf-8?B?VUkxQXJSbFJWY3NyZHVuMHBEMmlFcnYxYmppRUt6WEpRRXhVNjdJRm9lOWJt?=
 =?utf-8?B?UUI4YUdzTUVaNFhXU1crMlYvamQxUXRIR3FCaFFBbTJIVkhYM1Y2ZHc0LzRT?=
 =?utf-8?B?ZDAyRE5KUFdIYlVqUXNQTjFrek80RnR1cWpRN0htUy8rUzJYZWVlbzIwdm5K?=
 =?utf-8?B?RzJIOWU1TWMzZjJCSnpYeUxLMTVqZHBWcFl3UnhTbjFnVnhrOXJacitvaTEy?=
 =?utf-8?B?T3ZZV002L1dkT0x3c2Jkekd0TmtVdmJYTWJlVHJieGNYMFFSTDdPS0RzcWtJ?=
 =?utf-8?B?cExSeDdwZ0UxVjhQUFpHSzZEa3BoaE9RN2c3Zm9EQ0ZjWXh6ZmtJY1UxTlVj?=
 =?utf-8?B?MnNQWWtoMEluYmE5VXk1K1BLaDZMKy8yQkRjbVU1NjlWVnJBM3JnS0t0alNi?=
 =?utf-8?B?WEhjSDc2NE5HaVFJZW1YWTZXRUQxYkVzcmNKMWVzbERYT0hhMjIyUU04RGg0?=
 =?utf-8?B?VkU2THlwVmplQlVPY04wWGxKVHVRSFpPcGtSR2hFNkNhTzM0QjBKU3h4cDVn?=
 =?utf-8?B?dy9IRTVBMEtzU2ViQ0pMTkFyOE5Yek1CTThJaDNyblpQQThVUm9nU0o2ZndZ?=
 =?utf-8?B?dFI3S1VLYTk1U2oydFRpdGlGRENLckthV2JkeUp4UWNyaVJlWEpVMnovKzRy?=
 =?utf-8?B?MzVzZFZsaTh1d2VmUXliYXppYlpiZllFQktDcEdJQyt2dHZ4MDhUM0J1ODgr?=
 =?utf-8?B?SytTR0dVclBpVFBYaXVUYVZ4SURwRjRma1JaZFE2MHpUZHNQbFRDamIzSVV6?=
 =?utf-8?B?NDJxYmZxLzBtSjJtYkRlelVsbm8xd25ZdTBhamVrRDJjU0ZOZWN6ZGY1SmlG?=
 =?utf-8?B?RkxEbVlmYU8rSU5zTU1nWFY4Q2FaQTV2ZzJzRU1HM3ZHY2I1ZnVxazZrZWRz?=
 =?utf-8?B?ZXd2VHl1T2ZOZXFtNWhtVmFhenpiZUJvMlJZOXkvR241TFlxTE9KMk80dGZm?=
 =?utf-8?B?c3YwanlRMzUzejlYUHRNZTNIM0JRM0l5ZTByQkFUanhzSkVac0FnMU1STldN?=
 =?utf-8?B?NWFSNmhOeUp1dnFWRll3SnM5MXhDWjJZSFEvUGFoVDdvWDdpYUxiVVJLN1pW?=
 =?utf-8?B?aDVjN1QzM1IyTzdxQ1NYNTQ2aDZ4U0U5Y25QNldGb2wrSk8yQzVaUzlnVzhl?=
 =?utf-8?Q?nIfQR5aNbVIXFGQzwQ7vdI0=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ad797a5-d633-48bf-5b08-08d9c14ea57c
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 11:16:17.9647
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oywGVI3aKItKbjFv+l6Au3RHAytCKzKh0j+0ounDscHyruR8lgWQtvayUy/Ba1l1ekWnBgtlhPp2ajBVyMz+ag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5396
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 14/12/2021 15:38, Robin Murphy wrote:

...

>> IOMMU/DT folks, any thoughts about this approach? The patches that are 
>> of interest outside of Host1x/TegraDRM specifics are patches 1, 2, 4, 
>> and 5.
> 
> FWIW it looks fairly innocuous to me. I don't understand host1x - 
> neither hardware nor driver abstractions - well enough to meaningfully 
> review it all (e.g. maybe it's deliberate that the bus .dma_configure 
> method isn't used?), but the SMMU patch seems fine given the Kconfig 
> solution to avoid module linkage problems.


Thanks Robin! Will, Joerg, is OK with you?

Mikko, I believe we are missing a dt-binding change to document the 
'memory-contexts' node which I assume you will add if everyone is OK 
with this?

Cheers
Jon

-- 
nvpublic