From:   Vasily Averin <vvs@virtuozzo.com>
Subject: [PATCH] ksmbd: force "fail immediately" flag on fs with its own
 ->lock
To:     Namjae Jeon <linkinjeon@kernel.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Steve French <sfrench@samba.org>,
        Hyunchul Lee <hyc.lee@gmail.com>
Cc:     Bruce Fields <bfields@redhat.com>,
        Jeff Layton <jlayton@kernel.org>, kernel@openvz.org,
        linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org
Message-ID: <bdd6f570-f387-0371-09fb-d7b8c9993e8b@virtuozzo.com>
Date:   Fri, 17 Dec 2021 14:23:59 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGpXcURIbGpDazBqWnY0Q0tJNGZlcThaMXUwTU5JakI2bFFKK3R3b25TTTJC?=
 =?utf-8?B?Ry9WOEFjU1RWbXJjOVJzamlnRFJjeWg2aU0wc1ZUSEJ0K24yUjB3N3h2MTVQ?=
 =?utf-8?B?YS9ZSktQbmRmRmRselZTcFpOWENpdGhoVzgzdXN6WEg5MmEzbVpheTdhYkVh?=
 =?utf-8?B?MTFmdmVCVGJwOWRVWHZUQUVFYTJrZ3ZpTHBlcGVTQXljTmp5bHRYUUhlNy9Q?=
 =?utf-8?B?TWc5Skl4TWtWQ05xeDcvQXZsZW5HSlZsak1FRjFMVy8zd3FaS0RFaGJlUmw4?=
 =?utf-8?B?OFhJMVZ5Zy9ZeVhKWkNPL2tjZ2JvR1hJbkNMS3cxZzE4NHcvUGw5Q24rSHpv?=
 =?utf-8?B?eWkwREJZcVhLSVBSNlptQnpZRXNXRHg3NThCY20ya2Npd1pDZThWTHkzRFpy?=
 =?utf-8?B?T1U0ekpHVkNTQjZTNFBnMW1xK3dRRGlQNHpjQ05DR2U2VGozaVpPSVg4YWVE?=
 =?utf-8?B?ajY3aDNYTm5STUttZ1lUbElJY3BDcnFSNlZzL3AzbnhlVS9EejhWSStZL3N2?=
 =?utf-8?B?aE5ON1lFNnkrNDFsQzhzeWhNYUtRcElheitXcWdIUmlhblR2SGFkMzVVTGFV?=
 =?utf-8?B?TklTdUdTWWtsRHhHdEVrd0tPYVYyaVEwcHJHZEtDS1ltYWhqMFgzSW9jSHpx?=
 =?utf-8?B?amtNNXNkYkY0RFhibGR0dXcxNjhvdXhucnh1Qmt3Uk1UbDg4QitObm55ejR3?=
 =?utf-8?B?K0k3eTNGeDlMcmpqNnRTTEk5bUtKRDIvditpbFlxd0Z4OUs1NWVmQVBpdlU3?=
 =?utf-8?B?TDYxU1Q0ZU5OdzAvR0FzT3I4SnV4Si93bWljYkdEVU1aZllqU1pEby9ValR6?=
 =?utf-8?B?NlFiTDJJVlNVOVlUemVzMTFXaEtwNEhqN00zMHN2SEo3Qitaam81eXRoK3Rh?=
 =?utf-8?B?MUtvdDZGdXovdG1OcHJaZCtPVVpxNEM0MzIrdXowSHZiR0FaTlhJTjJDVHVk?=
 =?utf-8?B?VEEwM2JpbjlzbUgxOEVoTER3aytvZ3IxNGt2bUxZUFZTc0czSWxKbW9FLzFP?=
 =?utf-8?B?bTNuc3k5Uldyd2svL2xzZ3lCcVFvd0xSaHpRT1h0MkVNTnRnNHVGb1VYRXFR?=
 =?utf-8?B?Z1czZkpHRXVzZU9rQjdpNUFmL2ZwdFVkdlE4Nk92QlNoN0RJK21iTGVCNlh1?=
 =?utf-8?B?dTZZY1pOZXVXUFhYMmphY2g5R2xlWkUrYVZPZVVHTksrL0NEMFFhUUliUVNC?=
 =?utf-8?B?T3Q5cWtiU1FpeEUyNWszODhSc3MzakN6NHlTbitaUlA2UENLZGFqTUJ5WnhS?=
 =?utf-8?B?UEpxaEgyWnNlUnV3dTVmWm9LYXA4N05KRHFxeGwvREF6TTN3V3dLTUVid3BY?=
 =?utf-8?B?Y2FyOCtvS1FIU0FhcnVsNXdRWU83UEE4M2VOTks1TkpGWEp4N1ZiaWVpR1VT?=
 =?utf-8?B?Sy9rWllBT2JuREV0NGlSSWFKM0l6SFpoajY3dU0zT1RhRWNEMkFrenZsVXVm?=
 =?utf-8?B?UHM4VXRMbFBVRUhRT2ZnVVQxTkhLUFhmWks1T3J2MUFwc1Y3d1R3YndIM2Zh?=
 =?utf-8?B?Q2RPVlBHMGxxWDZydEFXUDNDdW9zOUhUVm8vNWVTVFp6OGptOEdSNWxFZ3BT?=
 =?utf-8?B?YVRGR1RkVjhibTNmaUUyMUlHSzVzSUxTVUFpRURBL3lMSnJjRk9CMHYveUxV?=
 =?utf-8?B?UXlaT2FnK3J0SVpQb1RLanl5VUFBMU04clM5OC94RDRBdDNqZTBiNi9OelFI?=
 =?utf-8?B?dWFQV2F3WlZ4TG5XYjBDQmFvTVhYTHhJcmRkZ3NVUVNXcVFXU3BvYmZ2bkI0?=
 =?utf-8?B?aTY0QzBVNk9ocHlOTFN5UTBHVFIzdWwxUzh4YXR3VUxnVktyWHRiWFYvZ1pS?=
 =?utf-8?B?cU5WUXBIVmg4T1BidExuTmFtdVVDdDdYOUpVYzBTUTY0d0NIUmlkSG84YzJX?=
 =?utf-8?B?RU1SZGhwbkhjR2ZrOXFhMVZFeWpGRUhURmtESVVLeDJwNjhhR1R0VVEvR3Zt?=
 =?utf-8?B?MkJqbkxpVU53enNuUUtxdkFYYW1XTlJGZEJxQmczMjFFdmFMbTd4a1BUMzY1?=
 =?utf-8?B?c1E3SFVIUEJYbVpPVGVlZE9OZG5QTXRFSU9vQVRjY1pMS0ZtU3dFRG45UGZY?=
 =?utf-8?B?K3J0bjVHSHdENStQeWQ2OEpFL0xsNmNaR2YzU3hPaktBclFJcGd1blVoc1pV?=
 =?utf-8?B?V3dTV1VxSjVQRXd0RlI2M3VBbGNCWG9yTncwcGZCa0ttWEk0NDRvQmFaQ1Vt?=
 =?utf-8?Q?N4MzpcGp0FBuve0PZPuvZQo=3D?=
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1fc7cc7e-bb5f-4e5c-d302-08d9c14fb9c0
X-MS-Exchange-CrossTenant-AuthSource: DB9PR08MB6619.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 11:24:01.4805
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5v6qSBgtf2IM4TPhRis2ceVaoiq24yLieMT6tipubyrRymusfadjVkayhTYfAYA4dM+0yxP3x8kTsyx2k2mpOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2311
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Like nfsd and lockd, ksmbd can cause deadlock if the exported
file system does not support asynchronous processing of blocking locks:
if all ksmbd worker threads handles such requests,
they can never finish and the server will not be able to handle
any other incoming requests.

Any filesystem that leaves ->lock NULL will use posix_lock_file(), which
does the right thing. Simplest is just to assume that any filesystem
that defines its own ->lock is not safe to request a blocking lock from.

To work around the problem we need to drop fl->fl_flag FL_SLEEP before
vfs_lock_file() execution, it forces affected functions to avoid blocking.

Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
---
 fs/ksmbd/smb2pdu.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
index 121f8e8c70ac..f2225491af02 100644
--- a/fs/ksmbd/smb2pdu.c
+++ b/fs/ksmbd/smb2pdu.c
@@ -6634,6 +6634,12 @@ static int smb2_set_flock_flags(struct file_lock *flock, int flags)
 {
 	int cmd = -EINVAL;
 
+	if ((flock->fl_file->f_op->lock) &&
+	    ((flags == SMB2_LOCKFLAG_SHARED) ||
+	     (flags == SMB2_LOCKFLAG_EXCLUSIVE))) {
+		ksmbd_debug(SMB, "force fail immediately request\n");
+		flags |= SMB2_LOCKFLAG_FAIL_IMMEDIATELY;
+	}
 	/* Checking for wrong flag combination during lock request*/
 	switch (flags) {
 	case SMB2_LOCKFLAG_SHARED:
-- 
2.25.1