Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.20.0.1.32\))
Subject: Re: [PATCH] ath10k: support bus and device specific API 1 BDF
 selection
From:   Thibaut <hacks@slashdirt.org>
In-Reply-To: <CAOX2RU6qaZ7NkeRe1bukgH6OxXOPvJS=z9PRp=UYAxMfzwD2oQ@mail.gmail.com>
Date:   Fri, 17 Dec 2021 13:25:28 +0100
Cc:     Christian Lamparter <chunkeey@gmail.com>,
        Kalle Valo <kvalo@kernel.org>, kvalo@codeaurora.org,
        davem@davemloft.net, kuba@kernel.org, ath10k@lists.infradead.org,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <EC2778B3-B957-4F3F-B299-CC18805F8381@slashdirt.org>
References: <20211009221711.2315352-1-robimarko@gmail.com>
 <163890036783.24891.8718291787865192280.kvalo@kernel.org>
 <CAOX2RU5mqUfPRDsQNSpVPdiz6sE_68KN5Ae+2bC_t1cQzdzgTA@mail.gmail.com>
 <09a27912-9ea4-fe75-df72-41ba0fa5fd4e@gmail.com>
 <CAOX2RU6qaZ7NkeRe1bukgH6OxXOPvJS=z9PRp=UYAxMfzwD2oQ@mail.gmail.com>
To:     Robert Marko <robimarko@gmail.com>
Precedence: bulk


> Le 17 d=C3=A9c. 2021 =C3=A0 13:06, Robert Marko <robimarko@gmail.com> =
a =C3=A9crit :
>=20
> On Wed, 8 Dec 2021 at 15:07, Christian Lamparter <chunkeey@gmail.com> =
wrote:
>>=20
>> Isn't the only user of this the non-upstreamable rb_hardconfig
>> mikrotik platform driver?

The driver could be upstreamed if desirable.
Yet I think it=E2=80=99s quite orthogonal to having the possibility to =
dynamically load a different BDF via API 1 for each available radio, =
which before this patch couldn=E2=80=99t be done and is necessary for =
this particular hardware.

>> So, in your case the devices in question
>> needs to setup a detour through the userspace firmware =
(helper+scripts)
>> to pull on the sysfs of that mikrotik platform driver? Wouldn't it
>> be possible to do this more directly?
>=20
> Yes, its the sole current user as its the only vendor shipping the BDF
> as part of the
> factory data and not like a userspace blob.
>=20
> I don't see how can it be more direct, its the same setup as when
> getting pre-cal
> data for most devices currently.

Indeed, not sure how it could be more direct than it already is. I=E2=80=99=
m open to suggestions though.

> I am adding Thibaut who is the author of the platform driver.

Best,
Thibaut=