Date:   Fri, 17 Dec 2021 12:37:30 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     matthias.bgg@gmail.com, lgirdwood@gmail.com,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] isoc: mediatek: potential use of error pointer
Message-ID: <YbyEigc8o5zxrEIh@sirena.org.uk>
References: <20211217120845.628024-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="zMLeK8tkMwZF4Dyq"
Content-Disposition: inline
In-Reply-To: <20211217120845.628024-1-jiasheng@iscas.ac.cn>
Precedence: bulk


--zMLeK8tkMwZF4Dyq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Dec 17, 2021 at 08:08:45PM +0800, Jiasheng Jiang wrote:

> -	for (i = CLK_NONE + 1; i < CLK_MAX; i++)
> +	for (i = CLK_NONE + 1; i < CLK_MAX; i++) {
>  		clk[i] = devm_clk_get(&pdev->dev, clk_names[i]);
> +		if (!clk[i])
> +			return ERR_PTR(-ENOMEM);

That's not how to check the error code from clk_get(), still has the
problem with unconditionally using -ENOMEM.  Please at least check that
the patches you are sending build...

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

--zMLeK8tkMwZF4Dyq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmG8hIkACgkQJNaLcl1U
h9AwEgf+MymMJRprn0AO42rTHOUqzPhgzGnAPqUzKB/o0cBQ6ykHPPVr+u/U1OEc
Zb3iwpu8LKn89t+Dg9mYzkax6PHyT2LE/mhKUJWfBGsCIj22EeJXWweiIKra3RYO
cLek+igwWU0uw+g4BTJpdMvQ3U7+a1+Y83aEHqy2d8pefzwSVZLLId1Pjq9kwEYT
y+fOjTe4rrQtu9JD6AXLiJWiUlbuzeENh6pif2LpkDTIciOGzAX4AFLuxqxZcdxi
/5fBBxUGo9XT/xlKfO8lDKAzmiLXIj9BDW9QK2PgVMYRIuKLJFO9s5KQVwDazCRr
m1gsMsi/R3F9wy/ejTujdvrni+N6Lg==
=txnz
-----END PGP SIGNATURE-----

--zMLeK8tkMwZF4Dyq--