Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74DD2C433F5 for ; Fri, 17 Dec 2021 13:15:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236610AbhLQNPO (ORCPT ); Fri, 17 Dec 2021 08:15:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233996AbhLQNPN (ORCPT ); Fri, 17 Dec 2021 08:15:13 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74854C061574; Fri, 17 Dec 2021 05:15:13 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id o20so7612124eds.10; Fri, 17 Dec 2021 05:15:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Na3iE0j4HNoWRi+U++Qkwp+ou8+ZuFrwaRIy0WfQ2hA=; b=N1jr9myxISWFLN1mOI/vHIm7ZWB08fTKGVaFpYwQ27LZJHOjLxTnHX+mLbvy56Ha3e +BVHSX0+Yx6xtn1m2T1ICDsnOmPq3bbHQOdrd/l/fQ9ymJcU9DHC1Q3Wd4eQwRs1irAb w4QUWGBiNrBEq0UHs2n+58YHaxjSOU9CzA8xUunvBR7P+eMZVAiLVlhDonXwWiiSkod9 FWKCaEFXjoQPgOD4IowjyWGxZ90LuM17iceNFjjXlBPjORhF7Q4doIEUi66Yz/QyKxeW R1Bl5iIjHMIx/qhhCLl9eowquoy8Mfj5HAakVqzMNmKZnjwr5ws+V7SWS0vIvxV6jZKb YiRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Na3iE0j4HNoWRi+U++Qkwp+ou8+ZuFrwaRIy0WfQ2hA=; b=BAXPUBKS/PojNyN+fjFM1IrtQPsjarsQCmn6fqZ7rkY/9v4ddDlYVMOVlqYwtVPL09 p8+HCG6GOJy1NV4hPcCWnbqHWREilpBNIV/IlmYb/jZh9L/Mgty6NpFIGcJqOGVWfoJY cvTegmoUDwSRLfF/TujgSx7PH5bTPr0TPPkwyM4+iQldbG+JD1Q5d4JF1J/Sdh3wdmCs kzXD7Nxd+BX/i1tsop3FnltIohq0zhgeuTSx8ygvOJ4qA8/HH/INKWb4wySNwt5Zcw7A DsUevkx6ioaGkkPkdbVquRCWxcQLa5nt0WoNN8HVy04BtB6bQA6p8tQJx5Rxze662vFe qXyA== X-Gm-Message-State: AOAM533V4Btl207gAffRtNum3I4vy0np6VsrUHzMnGAXjGVydUYGFG5z qtyax/G5FBXHXwPbkWNkItFapaHOdalErHPgI0U= X-Google-Smtp-Source: ABdhPJx2oXs11DBrV0D1boS6MZsPcSRGc/jvpGyJdpjBOAPI0LrBX/9/U5OOGPw9HCXw3XqnpD70MU3f84YkxWLJuzg= X-Received: by 2002:a17:907:2d12:: with SMTP id gs18mr2529014ejc.198.1639746911717; Fri, 17 Dec 2021 05:15:11 -0800 (PST) MIME-Version: 1.0 References: <20211106183802.893285-1-aford173@gmail.com> <718f7f6d6cd564d031c1963f1590c62d549ae725.camel@ndufresne.ca> <8db00a4b6faa99c940d9bc86e17161eb0db5efe3.camel@ndufresne.ca> <7f94eaacfddb8c5434c17f1e069ea87a17657ce9.camel@ndufresne.ca> In-Reply-To: From: Adam Ford Date: Fri, 17 Dec 2021 07:15:00 -0600 Message-ID: Subject: Re: [RFC 0/5] arm64: imx8mm: Enable Hantro VPUs To: Ezequiel Garcia Cc: Tim Harvey , Nicolas Dufresne , linux-media , Schrempf Frieder , Marek Vasut , Jagan Teki , Adam Ford-BE , cstevens@beaconembedded.com, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Greg Kroah-Hartman , Heiko Stuebner , Lucas Stach , Joakim Zhang , Alice Guo , Peng Fan , "open list:HANTRO VPU CODEC DRIVER" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , open list , "open list:STAGING SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 16, 2021 at 10:49 PM Ezequiel Garcia wrote: > > Hi Adam, > > > > > I will post a V2 last today with the Mini's post-processing removed. > > Someone, I apologize that I forget who, mentioned it was fused out of > > the Mini, so the testing I've been doing was with that removed and I > > removed the H1 encoder since the Mini doesn't support JPEG encoding. > > > [...] > > Resurrecting this thread here. IMX8MMRM Rev. 0, 02/2019 mentions > post-processor features for G1 and G2. > > Have you checked the fuse and synth registers to see if they throw > any useful information about the hardware? For instance, > comparing PP fuse register (SWREG99) and > Synthesis configuration register post-processor (SWREG100) > in both 8MQ and 8MM could be useful. > > As I mentioned on my previous mail, even if G1 PP is disabled > on the Mini, I would imagine the G2 can do linear NV12 (aka raster-scan) > which in our hantro driver jargon is a "post-processed" format :-) You're likely right. I was going on memory from an e-mail from Nicloas Defresne who wrote: "I will check the patchset, but you need in the mini-variant to disable the G1 post processor, because this block was fused out. We didn't make it optional from the start as according to the V1 of the TRM it was there, but that error was corrected in V3." In my head I assumed the G2 was affected as well, but when I double checked his email, and based on the above statement, the G2 post-processing is probably there, so I'll run some tests with the G2 post-processing enabled. I'll also double check those registers on both to confirm what they read. I am not sure when I'll have time because I leave for London next week, and I won't return until early January, but I'll do what I can. adam > > Thanks, > Ezequiel