MIME-Version: 1.0
Date:   Fri, 17 Dec 2021 15:30:02 +0200
From:   Jyri Sarha <jyri.sarha@iki.fi>
To:     Javier Martinez Canillas <javierm@redhat.com>
Cc:     linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Tomi Valkeinen <tomba@kernel.org>
Subject: Re: [PATCH v2 36/37] drm/tilcdc: Add support for the nomodeset kernel
 parameter
In-Reply-To: <20211217003752.3946210-37-javierm@redhat.com>
References: <20211217003752.3946210-1-javierm@redhat.com>
 <20211217003752.3946210-37-javierm@redhat.com>
Message-ID: <0e12f51baaf76b9863b4ab11fdb86af6@iki.fi>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021-12-17 2:37, Javier Martinez Canillas wrote:
> According to disable Documentation/admin-guide/kernel-parameters.txt, 
> this
> parameter can be used to disable kernel modesetting.
> 
> DRM drivers will not perform display-mode changes or accelerated 
> rendering
> and only the system framebuffer will be available if it was set-up.
> 
> But only a few DRM drivers currently check for nomodeset, make this 
> driver
> to also support the command line parameter.
> 
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>

Acked-by: Jyri Sarha <jyri.sarha@iki.fi>

> ---
> 
> (no changes since v1)
> 
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index cc567c87057d..eee3c447fbac 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -604,6 +604,9 @@ static struct platform_driver 
> tilcdc_platform_driver = {
> 
>  static int __init tilcdc_drm_init(void)
>  {
> +	if (drm_firmware_drivers_only())
> +		return -ENODEV;
> +
>  	DBG("init");
>  	tilcdc_panel_init();
>  	return platform_driver_register(&tilcdc_platform_driver);