Date:   Fri, 17 Dec 2021 14:41:14 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     matthias.bgg@gmail.com, lgirdwood@gmail.com,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] isoc: mediatek: potential use of error pointer
Message-ID: <Ybyhir3PjKii/yok@sirena.org.uk>
References: <20211217143551.675368-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="d0USlWQysP9phstr"
Content-Disposition: inline
In-Reply-To: <20211217143551.675368-1-jiasheng@iscas.ac.cn>
Precedence: bulk


--d0USlWQysP9phstr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Dec 17, 2021 at 10:35:51PM +0800, Jiasheng Jiang wrote:
> The return value of devm_clk_get() needs to be checked.
> To avoid use of error pointer in case of the failure of alloc.

Please don't ignore review comments, people are generally making them
for a reason and are likely to have the same concerns if issues remain
unaddressed.  Having to repeat the same comments can get repetitive and
make people question the value of time spent reviewing.  If you disagree
with the review comments that's fine but you need to reply and discuss
your concerns so that the reviewer can understand your decisions.

--d0USlWQysP9phstr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmG8oYkACgkQJNaLcl1U
h9CHMgf+JJKucdSSOzHdvJK5oPUKPzOqgM/6veVDk3VPfJb48zMOSmHGfgd1Bim0
oMf5jgOlMZvniPZkz0b/BzGw72b8eTpnHfTqN7tOn5wZAfqyVH7rrC/VJUoPvh4S
6f6dnpPtEt3H83Nqpt2kdc/75qyeUpQxg29ZVA7WwxDQlwOolAXSlzw7fTR9xhmB
D5NBvRtjOleL+tnj0CYmaMzU08jcixi7RAEyp9+KmIvfgfsWXm/x1QEQmg8zcf79
divhLW9uAg13qwgst7ukkqS4Hej0mzm3AqwQ7OEt4QbEr/LibgBPrL2JboAQdlJi
FAfMsmze8wv0V3zbB0qGe5holN1FLQ==
=1UVU
-----END PGP SIGNATURE-----

--d0USlWQysP9phstr--