Sender: Guenter Roeck <groeck7@gmail.com>
Subject: Re: [PATCH] hwmon : (mr75203) fix macro typo
To:     Andy Shevchenko <andriy.shevchenko@intel.com>,
        Arseny Demidov <arsdemal@gmail.com>
Cc:     rahul.tanwar@linux.intel.com, Arseny Demidov <a.demidov@yadro.com>,
        Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211216083302.986-1-a.demidov@yadro.com>
 <YbtK4mHxpdF5VtOk@smile.fi.intel.com>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <4a93a4cc-5b37-4524-add9-541bfbe3980e@roeck-us.net>
Date:   Fri, 17 Dec 2021 08:05:17 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <YbtK4mHxpdF5VtOk@smile.fi.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/16/21 6:19 AM, Andy Shevchenko wrote:
> On Thu, Dec 16, 2021 at 11:33:02AM +0300, Arseny Demidov wrote:
>> In the file mr75203.c we have a macro named POWER_DELAY_CYCLE_256,
>> the correct value should be 0x100. The register ip_tmr is expressed
>> in units of IP clk cycles, in accordance with the datasheet.
>> Typical power-up delays for Temperature Sensor are 256 cycles i.e. 0x100.
> 
> Should you provide Fixes tag?

Yes. Also, please update the subject. This is not about "fix macro typo".
it fixes a wrong/bad delay value.

> 
> ...
> 
>> -#define POWER_DELAY_CYCLE_256	0x80
>> +#define POWER_DELAY_CYCLE_256	0x100
>>   #define POWER_DELAY_CYCLE_64	0x40
> 
> I;m wondering why they are in hex? Perhaps the decimal is better for both.
> 
Maybe, but that is POV, and I tend to leave it up to driver authors to decide.
It is definitely not something we would want to change as part of a bug fix.

Thanks,
Guenter