Date:   Fri, 17 Dec 2021 16:13:30 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     matthias.bgg@gmail.com, lgirdwood@gmail.com,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] isoc: mediatek: Fix dereference of null pointer while
 alloc fail
Message-ID: <Yby3Kk0SzEZwNkNu@sirena.org.uk>
References: <20211217152044.675428-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="b6+QGlVr4tfa7Dj9"
Content-Disposition: inline
In-Reply-To: <20211217152044.675428-1-jiasheng@iscas.ac.cn>
Precedence: bulk


--b6+QGlVr4tfa7Dj9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Dec 17, 2021 at 11:20:44PM +0800, Jiasheng Jiang wrote:
> The return value of devm_clk_get() needs to be checked.
> To avoid use of error pointer in case of the failure of alloc.

Please don't ignore review comments, people are generally making them
for a reason and are likely to have the same concerns if issues remain
unaddressed.  Having to repeat the same comments can get repetitive and
make people question the value of time spent reviewing.  If you disagree
with the review comments that's fine but you need to reply and discuss
your concerns so that the reviewer can understand your decisions.

I'm getting really annoyed with this...

--b6+QGlVr4tfa7Dj9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmG8tykACgkQJNaLcl1U
h9DQJgf+LWui0F0zp3H7cavKZQQNOaoXP8fwZwuHoKfVx807JPO42fGl0JyJpARY
wilxOhyTo+iwRlL17k91DhtZtYaMt7DnVU/hdWwYVPAQKBYSch4CMeqSCpabufRy
R1Jb8aAe2/NNG0p5UYDfw6mMTvAs0OHR9skp8xwBm/dEB7nNdwoskAC6uAH9KwaX
fXP6830m0EJ0kLmWaMsr7w4+9uBsc/mmYGVdD+i1gFGF+yGPakNPn0o7Sa/k1uDJ
e/qr7XEeLlLiwPjVWozmUGY0nxn5PcX1vw81e4GbXexqAsWQ/nf48eoWuPKsC0Yc
o8nVrgDaNnWUpZMdBHw+VStMyzYBVw==
=Cnk2
-----END PGP SIGNATURE-----

--b6+QGlVr4tfa7Dj9--