Date:   Fri, 17 Dec 2021 18:45:27 +0200
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Arseny Demidov <arsdemal@gmail.com>, rahul.tanwar@linux.intel.com,
        Arseny Demidov <a.demidov@yadro.com>,
        Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon : (mr75203) fix macro typo
Message-ID: <Yby+pwwCg4gagNEf@smile.fi.intel.com>
References: <20211216083302.986-1-a.demidov@yadro.com>
 <YbtK4mHxpdF5VtOk@smile.fi.intel.com>
 <4a93a4cc-5b37-4524-add9-541bfbe3980e@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4a93a4cc-5b37-4524-add9-541bfbe3980e@roeck-us.net>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Dec 17, 2021 at 08:05:17AM -0800, Guenter Roeck wrote:
> On 12/16/21 6:19 AM, Andy Shevchenko wrote:
> > On Thu, Dec 16, 2021 at 11:33:02AM +0300, Arseny Demidov wrote:

...

> > > -#define POWER_DELAY_CYCLE_256	0x80
> > > +#define POWER_DELAY_CYCLE_256	0x100
> > >   #define POWER_DELAY_CYCLE_64	0x40
> > 
> > I;m wondering why they are in hex? Perhaps the decimal is better for both.
> > 
> Maybe, but that is POV, and I tend to leave it up to driver authors to decide.
> It is definitely not something we would want to change as part of a bug fix.

Agreed on both points.

-- 
With Best Regards,
Andy Shevchenko