Date:   Fri, 17 Dec 2021 17:00:26 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     matthias.bgg@gmail.com, lgirdwood@gmail.com,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] isoc: mediatek: Fix dereference of null pointer while
 alloc fail
Message-ID: <YbzCKoKGpGgAtvdq@sirena.org.uk>
References: <20211217165220.675485-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="JJqGkUrwTom4jERC"
Content-Disposition: inline
In-Reply-To: <20211217165220.675485-1-jiasheng@iscas.ac.cn>
Precedence: bulk


--JJqGkUrwTom4jERC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Dec 18, 2021 at 12:52:20AM +0800, Jiasheng Jiang wrote:

>  		clk[i] = devm_clk_get(&pdev->dev, clk_names[i]);
> +		if (IS_ERR(clk[i]))
> +			return -ENOMEM;

As I and IIRC someone else pointed out there is an error code encoded in
the pointer if IS_ERR() is true, we should use that error code.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

--JJqGkUrwTom4jERC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmG8wikACgkQJNaLcl1U
h9C91Qf/fsxCTq7BvFkf3sXZV0g4NXhdBia8H6U+ehwqkyRqwj9irbhmFZPa5a5e
IvWxSJ4e6UBFtL3ej0eVCEj/xcJHytRBC492G3RI+Hr1XPNtpfBY/eaGIZQ5Q9HE
KbwQ/ScMeoYRW3sGHtczrQrmd/LTXY+H47hICtq8CNriO56N6O1iISaXaMeogyfp
RyefEBtM5IUhcZsqbAhOpa4+v6EO6tWu3fUwUexUNF2u4vJm5r+V/yZGQaxmypSj
ecQFljvyjpT04PL/GOlPqgV2/qgiwlRDsy3SjsGPyrNiR2FWzbOXXdDxfjnxQnVY
XO0+74eQQmR/fCFEuXZKe3xxubVPFA==
=/dDZ
-----END PGP SIGNATURE-----

--JJqGkUrwTom4jERC--