From:   Nadav Amit <namit@vmware.com>
To:     David Hildenbrand <david@redhat.com>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Hugh Dickins <hughd@google.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        David Rientjes <rientjes@google.com>,
        Shakeel Butt <shakeelb@google.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Mike Rapoport <rppt@linux.ibm.com>,
        Yang Shi <shy828301@gmail.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
        Michal Hocko <mhocko@kernel.org>,
        Rik van Riel <riel@surriel.com>,
        Roman Gushchin <guro@fb.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Peter Xu <peterx@redhat.com>,
        Donald Dutile <ddutile@redhat.com>,
        Christoph Hellwig <hch@lst.de>,
        Oleg Nesterov <oleg@redhat.com>, Jan Kara <jack@suse.cz>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
        Waiman Long <longman@redhat.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v1 01/11] seqlock: provide lockdep-free raw_seqcount_t
 variant
Thread-Topic: [PATCH v1 01/11] seqlock: provide lockdep-free raw_seqcount_t
 variant
Thread-Index: AQHX8znaqyMNBisG2UGD/gNtIc+9Gqw26UMAgAAHdICAAAXPAIAAAzIA
Date:   Fri, 17 Dec 2021 18:01:17 +0000
Message-ID: <3F35C81D-34DB-4EA0-BC5C-A13EB71524A4@vmware.com>
References: <20211217113049.23850-1-david@redhat.com>
 <20211217113049.23850-2-david@redhat.com>
 <38BCB153-7E7C-4AAD-8657-E5C6F9E1EF9B@vmware.com>
 <058e97eb-1489-3d59-c6ee-94175dc13134@redhat.com>
 <a832ca37-b078-6f62-f99f-b2703674c1d8@redhat.com>
In-Reply-To: <a832ca37-b078-6f62-f99f-b2703674c1d8@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uUkr+tp1UF1Ml4Fb7o277H9r/A3kdNwE7dXk4tH0tRD22HKX12jku0pdQ2uG?=
 =?us-ascii?Q?6QuLFF5OTCygisXRpR9Z0KfGTubA4mX0P4cKqpjRxGlEURJ45QG0lYuKUQtD?=
 =?us-ascii?Q?4mmH9c9H9r7hIeuLpj5yI8Fqd5DJmwvzSHmRzRGJLxHO+UoDP448OdFtdzNt?=
 =?us-ascii?Q?StGG1Ct7/J+2g2B2e8hGHTMIIH7CgVGGkFjpRkB8iKvgrROD0xVyny9x69TR?=
 =?us-ascii?Q?8IFz0n6Iu4u/7yIro3y4zj2nQTiLlyN5CNSqJQmlAZo61nv/h6bUQouuiXdB?=
 =?us-ascii?Q?JaVGjw6yUqzYVxMNqnu7NZw8imgJfoV0hDtOWq+vauOBN3nYV0Csby4r36Ob?=
 =?us-ascii?Q?NIXA5Xlw03y1mH/i/JD/ltMvnA4XAOw2uzymQ26LOHo5kYp9QLDKTeaPzQLN?=
 =?us-ascii?Q?EzpSIlCwEmJOJdix6XpsvloKi1C9OmI+R0ktVYTMsrwdhhZ+xTyjD1obgf22?=
 =?us-ascii?Q?nXKxHaXSTDUg1z6+rkAhNpBr+SYnGEnyZR4n9Xw22kHpsHWkm5087uu0oMt/?=
 =?us-ascii?Q?gp0OzDdhmIA0SrE0azr48HArbM6LdrNgHc9OX4VkR/RsGsHpPDFo7PgitCJh?=
 =?us-ascii?Q?HPlxrBD0UuHgIhnIJhP4m/liXMKTdEsWPHzx4/LshZ6ehuyWeLxQA1YrSMLe?=
 =?us-ascii?Q?dcsh9Y9R9I/xvRE8HsnfHT4LnSFgzx59Rs3x6fmDbi61fGSPyXSnIEyKpxXi?=
 =?us-ascii?Q?adYRXZlnpyQ6QssqeG0BLupYQS9zb9LDH9cPSViR89lJ8yskm7o0eI7QEz3n?=
 =?us-ascii?Q?Ll9P4e44rX+DdKI7FBGwggFb6MS9ircVKhq5F0K97jiNtrxu5fT3/X+RcNDT?=
 =?us-ascii?Q?QGrWy3M5RNcJSqDOqiR7nTSHM4UrgQYXkyx7l9NfccrGOiYpwcT9Sv29Yx3w?=
 =?us-ascii?Q?ZaGlbAdKU+MYqu8iTB7m5NHIj80rhEQlPJC9WNKJjPAK7JpOZYnc5T2X0iqo?=
 =?us-ascii?Q?sXZOo1fmbwc2S9/OelbIBg3DdtxJKMeYV2LsqM55paCOTY06qe22X2pkIzHa?=
 =?us-ascii?Q?t1J2Tpw37MSZbLR/W0+bf0KhHw2lB5krcGkvEakF2M1X1ngZ+vdNwDoFx13V?=
 =?us-ascii?Q?yjrL6sYst3mS5J0+1YUlerqKqxOJb83C1kC2qSOEeVypZJb3HYb/thLZjJN8?=
 =?us-ascii?Q?YDCnQe41dfBLgFu2urHdaApFt9at8SHxhD5RA0jObS91JggElSzd0afsD810?=
 =?us-ascii?Q?50l7J8WHuZ3BcD45V8UBaXEcI/5YVToLbnI/oDKJkjTG17EZq4BfVEsdO+2g?=
 =?us-ascii?Q?txah4QU0+MSis6LTTuqiSFjEcd3MvL0svjYuoapszeMYbI5qWQ2LXRlOW2X6?=
 =?us-ascii?Q?4tHFOGSMiV6CdLVM9HhhQ1xDjq2qoHhOUJASLQpC0zqGCZ2oMzQK/xjcnIPh?=
 =?us-ascii?Q?NvSx+CT0qpK7ywmweydZsR8XZdlLYfaZl1/4F8kLEEjhfldDSwEfnvVdgvAt?=
 =?us-ascii?Q?DFPuk/uF9Kbp5/qOkR8eapNTu245sN5n7o2CFi74HCYDo45jqzMOQ/r7BPEA?=
 =?us-ascii?Q?3TGM1mqZrfsSFPS/rVGGR+KTW4kVJHPdg1WlyJ7A9XPQuov1yHEWXxvyT0i/?=
 =?us-ascii?Q?sJihZmAXel/Jj7kivJIcO5eK/AZY21K9CJ1Uq8Z8gPl54yjnOG+O/iU5fvDl?=
 =?us-ascii?Q?iRWFlHKhGBUb+4DzHcpNXs4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <AB8CBBD046C30343883FC8B66FBA3B49@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR05MB8531.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9517d1e-b9b4-41a3-11cd-08d9c1873927
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2021 18:01:17.2049
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X2feokE6j3vrUkD/rI1ednpjxGke2ycTmsRkI0Ov5/Qxszj8RsSWZXP4d1mDI4DlKsRZiZ5ZSy/n+ty1TaHA4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR05MB7143
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Dec 17, 2021, at 9:49 AM, David Hildenbrand <david@redhat.com> wrote:
>=20
> On 17.12.21 18:29, David Hildenbrand wrote:
>> On 17.12.21 18:02, Nadav Amit wrote:
>>>=20
>>>=20
>>>> On Dec 17, 2021, at 3:30 AM, David Hildenbrand <david@redhat.com> wrot=
e:
>>>>=20
>>>> Sometimes it is required to have a seqcount implementation that uses
>>>> a structure with a fixed and minimal size -- just a bare unsigned int =
--
>>>> independent of the kernel configuration. This is especially valuable, =
when
>>>> the raw_ variants of the seqlock function will be used and the additio=
nal
>>>> lockdep part of the seqcount_t structure remains essentially unused.
>>>>=20
>>>> Let's provide a lockdep-free raw_seqcount_t variant that can be used v=
ia
>>>> the raw functions to have a basic seqlock.
>>>>=20
>>>> The target use case is embedding a raw_seqcount_t in the "struct page"=
,
>>>> where we really want a minimal size and cannot tolerate a sudden grow =
of
>>>> the seqcount_t structure resulting in a significant "struct page"
>>>> increase or even a layout change.
>>>>=20
>>>> Provide raw_read_seqcount_retry(), to make it easy to match to
>>>> raw_read_seqcount_begin() in the code.
>>>>=20
>>>> Let's add a short documentation as well.
>>>>=20
>>>> Note: There might be other possible users for raw_seqcount_t where the
>>>>     lockdep part might be completely unused and just wastes memory --
>>>>     essentially any users that only use the raw_ function variants.
>>>>=20
>>>=20
>>> Is it possible to force some policy when raw_seqcount_t is used to
>>> prevent its abuse? For instance not to allow to acquire other (certain?=
)
>>> locks when it is held?
>>>=20
>>=20
>> Good question ... in this series we won't be taking additional locks on
>> the reader or the writer side. Something like lockdep_forbid() /
>> lockdep_allow() to disallow any kind of locking. I haven't heard of
>> anything like that, maybe someone reading along has a clue?
>>=20
>> The writer side might be easy to handle, but some seqcount operations
>> that don't do the full read()->retry() cycle are problematic
>> (->raw_read_seqcount).
>=20
> Sorry, I forgot to mention an important point: the raw_seqcount_t
> doesn't give you any additional "power" to abuse.
>=20
> You can just use the ordinary seqcount_t with the raw_ functions. One
> example is mm->write_protect_seq . So whatever we would want to "invent"
> should also apply to the raw_ functions in general --  which might be
> undesired or impossible (IIRC IRQ context).
>=20

Thanks for the clarification. I was unfamiliar with
raw_read_seqcount_begin() (and friends). Indeed it is very very rarely
used.=