From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Horatiu Vultur <horatiu.vultur@microchip.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>
Subject: Re: [PATCH net-next v7 9/9] net: lan966x: Extend switchdev with fdb
 support
Thread-Topic: [PATCH net-next v7 9/9] net: lan966x: Extend switchdev with fdb
 support
Thread-Index: AQHX81485q7W8Qj6DU+J0X6deflh6qw2/JiA
Date:   Fri, 17 Dec 2021 18:12:35 +0000
Message-ID: <20211217181235.wquhfoq6qyqsfkxp@skbuf>
References: <20211217155353.460594-1-horatiu.vultur@microchip.com>
 <20211217155353.460594-10-horatiu.vultur@microchip.com>
In-Reply-To: <20211217155353.460594-10-horatiu.vultur@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LPt/sASIw9cyM9/Ik9pAEI4gOBrsuBgL+nMg0s3EEnd0/mkigBxEMxkCCvnV?=
 =?us-ascii?Q?2T+7sK8TYyiAUOX2UquGongZSfCwnXc3t7Ct3vwJivU/kkbAXOFSrDcuLPpU?=
 =?us-ascii?Q?pXnrpc9uwzqhtTn3BC1kGs/MNsUy6czptIH7KfxSGFNLDsvOEXZM6Czju3lU?=
 =?us-ascii?Q?1NzQ+dYdyuCa6vuV2ao74Gg11fFNU9j/viTCGciX9AHinfpoxIFbp52keWyb?=
 =?us-ascii?Q?bW/buXUaerWc5WUFkcUPGQnUY57lVU9jvTZwe/y/hPvSOFPGWVpVQ+4AL3ic?=
 =?us-ascii?Q?FTO4zWFCGlQX/HvnXf5N8BQDG5513NMhfFnUtXd8tCD55fjI+cybliYnCzjP?=
 =?us-ascii?Q?Zil1mK7QFqr+UNkqye61Vo5kWejKHfpuj16yBDiL6DqbJO+L+OMb1u08p9Hw?=
 =?us-ascii?Q?ZE2F4j5nEKZxG9AtQbxL5Sa1uzmT2AnaLUO5y0hlZQSXzR2prAuQDpynMh5L?=
 =?us-ascii?Q?kfhEYIvC1rDIykUaIxZPw/JF7dyMNBs//4DfFc3paF4LBnmaFWYmAjTiBUR5?=
 =?us-ascii?Q?JIakH18bUaM9eBHlvnpvrDzvVUbcRi4hivyFnIYoDsIlAUldRropsZHpUFkj?=
 =?us-ascii?Q?u8+A6XaTMk5OAeqk7wCCfhBb69pMzn15AtWKhiOqY1P7xwcG0SQgY15nnCBl?=
 =?us-ascii?Q?fhOY8769AUr1Ra3HStRLw8c2RsYIksu9P751FX7yhKarCXkFDT4j1cLDr9fc?=
 =?us-ascii?Q?fI/23ADfk8++1dhHlvEFxTLt+bbZYofbO1EZnadmoMB/oPrErxMq9VhwYM17?=
 =?us-ascii?Q?CR9YghnZtQYiyveeUIRCknRJcB9V7C9V7vo9hNXxgePTdIrw+Erwrr91+goX?=
 =?us-ascii?Q?RDa+IljjlWO7jOLgnDrxhCIg9ZJdYEKysWsTIHAL0ZfJ8NyvbG/8lz6ZyXJm?=
 =?us-ascii?Q?AIJXbKtwTRLI2fjxjfnE7n/msuzccSi+M/2pYByqkl0aNfV+iVivXCJnVnbu?=
 =?us-ascii?Q?Lz03fdapWd02TYc33/n399n31i+H7VUTLjvEj/bTb5ZhDRD0fUh7wBVslle7?=
 =?us-ascii?Q?P7K5Alxi+rVQ3/DTofHx6DwEjJLDJ4sBWeHbE3uG5TCFn9UTOrKHgUKZNBcH?=
 =?us-ascii?Q?D2hLGZuykzQp1Cy6Bj62bzfM2ZFpAoZySy/MiFVIN5BsDUCiuhoGKtkFgWwt?=
 =?us-ascii?Q?mjOJx2TEaFokA1s3pnOCoYjhq0eQM9JU3WLMPHSk3GBQNpo3cIUkdhVxzrWX?=
 =?us-ascii?Q?UGcm8E3Ndq+O4Y9NerdaxejKCDQxIPBLsxxpq8mDj2r5WrgNs2op8Exv7i5A?=
 =?us-ascii?Q?yybyr8EqtMqmfYKLwoNPHhuTVmK6y5bmGEKTaNVOFj130zUZXHybNJ8pSzma?=
 =?us-ascii?Q?WPFUJXblPUbkXtIBvKqDNhYpcIahlva5pGzWIP/QGB0+J8IBprB2WilTDx1N?=
 =?us-ascii?Q?xiZyDrkpBZbtd8G7MNORsHr4QhlSlsRyrnjTn1FE8HA0Bmx7JZ0SRJ2hoiYU?=
 =?us-ascii?Q?xGZR+5K+YSFLBNU3gdAfve8kdtt45l0EMUowwqobcDl663Us1WRZ4Nd4ne/q?=
 =?us-ascii?Q?J8y2C1NTvlQqiecmVF7MqebUfFzjDUCaQzB60F+BrQvbKgAHFBOzvm8mJXxv?=
 =?us-ascii?Q?0pOmfvfjqXBtwBlReWf+CL99lEamx+zPdK45JkxdF2YNWVBnL6M3VFVIbcbN?=
 =?us-ascii?Q?UjO8KQ0+ghgrBd24E92x1zQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8FAA79077FFBDD46A8A5618EE807DF89@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5121.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a5406aa4-c63e-4351-be51-08d9c188cdc2
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2021 18:12:35.9771
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UvZ0XTsyetXqMc+LRAroEK+yDvd1qR8FlTk6/QIVC/RQFHh5DtWo/6TBpJfjMHCe81jnUpjtKnVjKX5bJmNMSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6465
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 17, 2021 at 04:53:53PM +0100, Horatiu Vultur wrote:
> Extend lan966x driver with fdb support by implementing the switchdev
> calls SWITCHDEV_FDB_ADD_TO_DEVICE and SWITCHDEV_FDB_DEL_TO_DEVICE.
>=20
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---

Looks pretty good. Just one question, since I can't figure this out by
looking at the code. Is the CPU port in the unknown unicast flood mask
currently?

>  .../net/ethernet/microchip/lan966x/Makefile   |   2 +-
>  .../ethernet/microchip/lan966x/lan966x_fdb.c  | 244 ++++++++++++++++++
>  .../ethernet/microchip/lan966x/lan966x_main.c |   5 +
>  .../ethernet/microchip/lan966x/lan966x_main.h |  14 +
>  .../microchip/lan966x/lan966x_switchdev.c     |  21 ++
>  .../ethernet/microchip/lan966x/lan966x_vlan.c |  15 +-
>  6 files changed, 298 insertions(+), 3 deletions(-)
>  create mode 100644 drivers/net/ethernet/microchip/lan966x/lan966x_fdb.c
(...)
> +static void lan966x_fdb_add_entry(struct lan966x *lan966x,
> +				  struct switchdev_notifier_fdb_info *fdb_info)
> +{
> +	struct lan966x_fdb_entry *fdb_entry;
> +
> +	fdb_entry =3D lan966x_fdb_find_entry(lan966x, fdb_info);
> +	if (fdb_entry) {
> +		fdb_entry->references++;
> +		return;
> +	}
> +
> +	fdb_entry =3D kzalloc(sizeof(*fdb_entry), GFP_KERNEL);
> +	if (!fdb_entry)
> +		return;
> +
> +	memcpy(fdb_entry->mac, fdb_info->addr, ETH_ALEN);

ether_addr_copy

> +	fdb_entry->vid =3D fdb_info->vid;
> +	fdb_entry->references =3D 1;
> +	list_add_tail(&fdb_entry->list, &lan966x->fdb_entries);
> +}=