From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Horatiu Vultur <horatiu.vultur@microchip.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>
Subject: Re: [PATCH net-next v7 7/9] net: lan966x: Add vlan support.
Thread-Topic: [PATCH net-next v7 7/9] net: lan966x: Add vlan support.
Thread-Index: AQHX81427TYphMdvnUaVtzKVd/dm2aw2/SYA
Date:   Fri, 17 Dec 2021 18:14:35 +0000
Message-ID: <20211217181434.mfnur3nucfiykgto@skbuf>
References: <20211217155353.460594-1-horatiu.vultur@microchip.com>
 <20211217155353.460594-8-horatiu.vultur@microchip.com>
In-Reply-To: <20211217155353.460594-8-horatiu.vultur@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?x4ChnQtEOfOn7c2ZDY/FV4rOmMPMZwgluVgq0F7+qhIJy6SUF6+TG4kZHhZ8?=
 =?us-ascii?Q?4xC3uie68gy6iJPMqstAwTBAjH2FpN882MtkrNYCII/ztWkew5Tu0rySXrYS?=
 =?us-ascii?Q?oJOEWn1Mwsjg7nuq4dNbiYDPyZuIDWj/YaXMPLLZsw+8iCZBtryqzT7x7vfz?=
 =?us-ascii?Q?1fJXGLrMzTrDl2PcTY5XrsFxapM4gabe46VbUF+BJu1KsNqG87tiN4VtjFTq?=
 =?us-ascii?Q?tKJ+3Ux973eF9HZF5g+PFJNgi8Kmqmy/L9wtx/mns22ao2v0g5uAHhCRKRX0?=
 =?us-ascii?Q?UHpsCEO8xyKEDU/dE8iV9Iir5MRB5+bj2GUMZhBVSVyw0YKIbTfs5yvwZiAG?=
 =?us-ascii?Q?YZ1YEmo2Z0t4iVZru99fncIMBOcdZOCpfHVUWuy+xf7/QtHoMoH1KzVa9qZB?=
 =?us-ascii?Q?tpXh99/twbFTeq8xDSL/9/Jmc2GlURGKbhDaOQzF+4G2skN+cdmlXrgXJc5V?=
 =?us-ascii?Q?6dTGRI55xuzWXKVEiomAmqrZ4wwEy4guQGr7a9mup9/kgBbc2i/+caN7oI9V?=
 =?us-ascii?Q?pP65OfqCwLm66nnGsCFhncYxmye9sLooLU39A2pOJ62DazOOO5o+pRP5wB3W?=
 =?us-ascii?Q?waHF2vvx0sCwh99Hd6QC0TOG8B/N+g04HAQ2V3D0QO8shQfNwQDmvD2ZcFAA?=
 =?us-ascii?Q?DbiocyvsXQK7afmR9d7j2ODGeSCYgKOMRON5n7WD6Pnx38jjAwilLWlao0BO?=
 =?us-ascii?Q?azC44QEyduavTlo0kLZ4uZ+8ul+KJP21VpjippPjOJ2wCyBGqRa4TVFXmNnf?=
 =?us-ascii?Q?1mzJ999pJ6W+8Rw+jHEzwYW0DvAXeK2jI0yRZLs3KvzFbRDbN9sqySDfCSnk?=
 =?us-ascii?Q?wQezeKOlTcC1xjxRiryIWRlKbPoBeEJ6znMXc37GBlSF1YbIUJwhFyWDeQXn?=
 =?us-ascii?Q?RY6qwiGl6nSZTZxJ2ibuTLrkK0mStfdFfqeMQv06bPgjreHSNDsYf248s0NY?=
 =?us-ascii?Q?/+uXStOM1cYM//SpdYxdHs4yHShtNDNLX+RD7Z3sLvumxg8o2bi45xkh4uGq?=
 =?us-ascii?Q?Qw0Wt9vW2wJo0x4i9cd4VVnRKpezoLa2xp3DMIuals0vFFCKOKCczjvitVUp?=
 =?us-ascii?Q?o9YMIChC/VFvF/6IO9ZuRg/wKQWiUD6z0KPTia62Nt+jn9shbnC2XJp/ymNE?=
 =?us-ascii?Q?vEPZts61lUu2uNF6lHgjE5sBYP9TIEy6LdFlBVE1+HKPXtZ7XiJpg3HhHW0g?=
 =?us-ascii?Q?7Oo8XJaIFY3MR3xFDt1wgOW/F7oh4trqdO3F7Nx9RbSiD+wru8VeL78MQM19?=
 =?us-ascii?Q?mQEzj+jsuW81+wcAXYIyDt88CtiBdnj4zR0nB+WFHganff05tMI3E3YJggiL?=
 =?us-ascii?Q?CG8sp24oS0KYl6d6R8xl4XL/OLSPNOxt9cq673nzqCFyUJBanCFToTUaYTVF?=
 =?us-ascii?Q?GFy0aAtKGv7uMrVknRInGSDqZyetVALOdemuMWcry1CcsOcemLf7xlxf7ex5?=
 =?us-ascii?Q?ZtQq5wAzZKsbiOSpJYZb4cEy7pTiE9iuPmhOiMtcrVhkNXAumDHSQruEGhIt?=
 =?us-ascii?Q?B5nFCq+dGQ+yBHm3hd8NNpp5GS3iZ5AwDE+xR6KmWoZkvy4eiz2P1wiJOQ60?=
 =?us-ascii?Q?tK/pNj+ccoBMpKI/IWNF0Ztly2+eVP5KN6jFGwL20hN8cFpz2FQRmsDcCjpU?=
 =?us-ascii?Q?a4YkL8+4lHhcPb01/ixj6G8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9EF1BF9161A137479DB948D2622B182B@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5121.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f6000e43-3ace-4a0b-a4e1-08d9c189151b
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2021 18:14:35.6860
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 67aAr5x/qg64BMv3iZqoFMbFJaZJbgaH8pgROnioVDrKaQArzheM3jQxvC57iQOhJWAYKflPBABH6tWohcPyxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6465
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 17, 2021 at 04:53:51PM +0100, Horatiu Vultur wrote:
> @@ -120,7 +124,12 @@ static void lan966x_port_bridge_leave(struct lan966x=
_port *port,
>  	if (!lan966x->bridge_mask)
>  		lan966x->bridge =3D NULL;
> =20
> -	lan966x_mac_cpu_learn(lan966x, port->dev->dev_addr, PORT_PVID);
> +	/* Set the port back to host mode */
> +	lan966x_vlan_port_set_vlan_aware(port, false);
> +	lan966x_vlan_port_set_vid(port, HOST_PVID, false, false);
> +	lan966x_vlan_port_apply(port);
> +
> +	lan966x_mac_cpu_learn(lan966x, port->dev->dev_addr, HOST_PVID);

Do you still need to re-learn the port MAC address?

>  }=