From:   Thomas Gleixner <tglx@linutronix.de>
To:     Jing Liu <jing2.liu@intel.com>, x86@kernel.org,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        pbonzini@redhat.com
Cc:     seanjc@google.com, jun.nakajima@intel.com, kevin.tian@intel.com,
        jing2.liu@linux.intel.com, jing2.liu@intel.com,
        guang.zeng@intel.com, wei.w.wang@intel.com, yang.zhong@intel.com
Subject: Re: [PATCH v2 01/23] x86/fpu: Extend fpu_xstate_prctl() with guest
 permissions
In-Reply-To: <20211217153003.1719189-2-jing2.liu@intel.com>
References: <20211217153003.1719189-1-jing2.liu@intel.com>
 <20211217153003.1719189-2-jing2.liu@intel.com>
Date:   Fri, 17 Dec 2021 19:45:18 +0100
Message-ID: <8735mrcbpd.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Fri, Dec 17 2021 at 07:29, Jing Liu wrote:
>  
> -static int __xstate_request_perm(u64 permitted, u64 requested)
> +static int __xstate_request_perm(u64 permitted, u64 requested, bool guest)
>  {
>  	/*
>  	 * This deliberately does not exclude !XSAVES as we still might
> @@ -1605,6 +1605,7 @@ static int __xstate_request_perm(u64 permitted, u64 requested)
>  	 */
>  	bool compacted = cpu_feature_enabled(X86_FEATURE_XSAVES);
>  	struct fpu *fpu = &current->group_leader->thread.fpu;
> +	struct fpu_state_perm *perm;
>  	unsigned int ksize, usize;
>  	u64 mask;
>  	int ret;

needs to be

      int ret = 0;

Do not blindly copy code from that Gleixner dude...

Thanks,

        tglx