Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA44C433FE for ; Fri, 17 Dec 2021 21:03:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240975AbhLQVDo (ORCPT ); Fri, 17 Dec 2021 16:03:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbhLQVDn (ORCPT ); Fri, 17 Dec 2021 16:03:43 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43A22C06173E for ; Fri, 17 Dec 2021 13:03:43 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id n8so2894999plf.4 for ; Fri, 17 Dec 2021 13:03:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ywG3K+b0v1h1vdIosCw5UiVznpeUbvFW73m/kjIxzss=; b=ld7kptwqGnD4zk5IhoFmhvMK4R5EJnfGLnrMKQP5DDbv8WJ9B9CatvpCefcpFWKeMA 2BEcQfmwZkF9V6r5rqLsGYBg6BZu7ZwCTasBOnb1p9PrG4uSalG2hL3IbVK0P5b+pFNJ gMByKg/IcZj9Wfy6ol4DddS+VqVRbnjKMJVSZrswjwlOmk3H0GG1vh9IgX352Jn07yAm kpcxj78x9j171y98iRjpt6QWN8IusAkB/uti3XxaJXWDiuRv4Vjsz2KvsERTCieACJfS sqQA8JpLI5JqIzr5i1KioAdR03u/2MSWgxu3ADNcshoxHdsoOmAI1xm0HPEZpssnivnP ObsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ywG3K+b0v1h1vdIosCw5UiVznpeUbvFW73m/kjIxzss=; b=Y1yeGvZcz2PR6FWh7zpzcr4hvPGXHJJpT6tBx2cFI5SZq7VrdOZPoERs+JDp/P+GnE xgGA5dm08BrZuGIJ/8XH5bvcI2P3PyczqqBroMNFLiqHyQlGscZ+yd26tT+QvVZD9xDU 2DaTpcrJoh/tFTk+WqVqew0cpze/A/s3p5eCxgMWxvCupt2VuoDE3T2cxsNUKbHuQhpE XPR8GGTEyjs5g4vVAiawnMvZYjy1/WUBQ4JuTHnf/kzPiX9OMR/AMGLde8guaKiWFQwX lxz7YADTAzDhW7HZl5MV/gC1LsNK6xGcbnYKeFL6zWLWxNlewa3jCX5Js53bCwCtiOu8 Dp4A== X-Gm-Message-State: AOAM533ydVvJui5cZLrmwgomXfxYIqmyEqepxADhzgbt1Q57iewXXCYt 8ASP4VNVplZ8zpaAgXhWXhFk2g== X-Google-Smtp-Source: ABdhPJz+MLn1Xx7Uc9uThUDUYZ5pqe46UztRNM5KMmNkA7etR6yNz8Tlu0PiQsNJNWqbXmFESBlnxA== X-Received: by 2002:a17:902:7686:b0:148:cba4:26b0 with SMTP id m6-20020a170902768600b00148cba426b0mr4970263pll.2.1639775022794; Fri, 17 Dec 2021 13:03:42 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id 145sm9265280pgd.0.2021.12.17.13.03.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Dec 2021 13:03:42 -0800 (PST) Date: Fri, 17 Dec 2021 13:03:40 -0800 From: Stephen Hemminger To: Yevhen Orlov Cc: netdev@vger.kernel.org, Volodymyr Mytnyk , Taras Chornyi , Mickey Rachamim , Serhiy Pshyk , Taras Chornyi , Oleksandr Mazur , "David S. Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 6/6] net: marvell: prestera: Implement initial inetaddr notifiers Message-ID: <20211217130340.67cb775b@hermes.local> In-Reply-To: <20211217195440.29838-7-yevhen.orlov@plvision.eu> References: <20211217195440.29838-1-yevhen.orlov@plvision.eu> <20211217195440.29838-7-yevhen.orlov@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Dec 2021 21:54:38 +0200 Yevhen Orlov wrote: > +/* This util to be used, to convert kernel rules for default vr in hw_vr */ > +static u32 prestera_fix_tb_id(u32 tb_id) > +{ > + if (tb_id == RT_TABLE_UNSPEC || > + tb_id == RT_TABLE_LOCAL || > + tb_id == RT_TABLE_DEFAULT) > + return tb_id = RT_TABLE_MAIN; That is a useless assignment why?