IronPort-SDR: sfCja/5Et+X5cKx2ZcGFLKpZ1UGDsFgeOjMHRGVvd9Vi5QGdxjlNfUJF5D+OfvECkuTUtZGH/o
 6/X+oiXbAvn+7ha6qpUyQ2+5VcNM3SV4gQXv3RhjOEIEbkQs51QF5djMOL6qcO4qBm3fEJcyeC
 wxDtUZlS6Uxb56Ytj9jVfHCmvfm+Vw2bMoitjV690YySp5lLHsSSFd66PFcaHTUGa1po5cwUtS
 vugo0UPea9rF/f9txFXgDgSzrF1gQqxUkytzNwuMBUypqbSQMNx/AatGGczqPW8D0lTD76qKpZ
 /3t1ZJhmJINxdLt04ALuhvEc
From:   Yizhuo Zhai <yzhai003@ucr.edu>
Cc:     Yizhuo Zhai <yzhai003@ucr.edu>, stable@vger.kernel.org,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
        Wenjing Liu <wenjing.liu@amd.com>, Jun Lei <jun.lei@amd.com>,
        Jimmy Kizito <Jimmy.Kizito@amd.com>,
        Fangzhi Zuo <Jerry.Zuo@amd.com>,
        Meenakshikumar Somasundaram <meenakshikumar.somasundaram@amd.com>,
        Mark Morra <MarkAlbert.Morra@amd.com>,
        Agustin Gutierrez <agustin.gutierrez@amd.com>,
        Robin Singh <robin.singh@amd.com>,
        Anthony Koo <Anthony.Koo@amd.com>,
        "Guo, Bing" <Bing.Guo@amd.com>,
        Aurabindo Pillai <aurabindo.pillai@amd.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] drm/amd/display: Fix the uninitialized variable in enable_stream_features()
Date:   Fri, 17 Dec 2021 20:22:23 -0800
Message-Id: <20211218042226.2608212-1-yzhai003@ucr.edu>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
To:     unlisted-recipients:; (no To-header on input)
Precedence: bulk

In function enable_stream_features(), the variable "old_downspread.raw"
could be uninitialized if core_link_read_dpcd() fails, however, it is
used in the later if statement, and further, core_link_write_dpcd()
may write random value, which is potentially unsafe.

Fixes: 6016cd9dba0f ("drm/amd/display: add helper for enabling mst stream features")
Cc: stable@vger.kernel.org
Signed-off-by: Yizhuo Zhai <yzhai003@ucr.edu>
---
 drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index c8457babfdea..fd5a0e7eb029 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -1844,6 +1844,8 @@ static void enable_stream_features(struct pipe_ctx *pipe_ctx)
 		union down_spread_ctrl old_downspread;
 		union down_spread_ctrl new_downspread;
 
+		memset(&old_downspread, 0, sizeof(old_downspread));
+
 		core_link_read_dpcd(link, DP_DOWNSPREAD_CTRL,
 				&old_downspread.raw, sizeof(old_downspread));
 
-- 
2.25.1