Message-ID: <28c7a12e-6d85-d15d-8884-997eb68612e9@infradead.org>
Date:   Fri, 17 Dec 2021 22:07:21 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2][RFC 1/2] Implement Ziegler-Nichols Heuristic
Content-Language: en-US
To:     Chetankumar Mistry <chetan.mistry@arm.com>,
        linux-kernel@vger.kernel.org
Cc:     lukasz.luba@arm.com, rafael@kernel.org, daniel.lezcano@linaro.org,
        amitk@kernel.org, rui.zhang@intel.com, linux-pm@vger.kernel.org
References: <20211217184907.2103677-1-chetan.mistry@arm.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20211217184907.2103677-1-chetan.mistry@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/17/21 10:49, Chetankumar Mistry wrote:
> Implement the Ziegler-Nichols Heuristic algorithm to better
> estimate the PID Coefficients for a running platform.
> The values are tuned to minimuse the amount of overshoot in
> the temperature of the platform and subsequently minimise
> the number of switches for cdev states.
> 
> Signed-off-by: Chetankumar Mistry <chetan.mistry@arm.com>

The kernel-doc changes all look good and don't cause any warnings.
Thanks.

> ---
> Changelog v2:
> - Updated Kernel-Docs to use ':' delimiter (asked by Randy Dunlap)
> - Changed divide operation to use div_frac (requested by kernel_test_robot)
> 
>  drivers/thermal/gov_power_allocator.c | 418 ++++++++++++++++++++++++++
>  drivers/thermal/thermal_sysfs.c       |   2 +
>  include/linux/thermal.h               |   7 +
>  3 files changed, 427 insertions(+)

-- 
~Randy