References: <20211217125757.1193256-1-balbi@kernel.org>
 <20211217125757.1193256-3-balbi@kernel.org>
 <92001103-6b29-7ad9-eea3-34fd30c5f767@postmarketos.org>
User-agent: mu4e 1.6.10; emacs 28.0.90
From:   Felipe Balbi <balbi@kernel.org>
To:     Alexey Minnekhanov <alexeymin@postmarketos.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC/patch 2/2] arm64: boot: dts: qcom: surface duo: add
 minimal framebuffer
Date:   Sat, 18 Dec 2021 09:15:30 +0200
In-reply-to: <92001103-6b29-7ad9-eea3-34fd30c5f767@postmarketos.org>
Message-ID: <87lf0i4c2l.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Hi,

Alexey Minnekhanov <alexeymin@postmarketos.org> writes:
> @@ -472,6 +483,14 @@ &pon_resin {
>  	linux,code = <KEY_VOLUMEDOWN>;
>  };
>  
> +&reserved_memory {
> +	splash_region: splash_region@9c000000 {
> +		/* We expect the bootloader to fill in the size */
> +		reg = <0x0 0x9c000000 0x0 0x0>;
>
> 0x2400000 should be here as size, maybe?

bootloader is filling that up, but sure I only used this to get the size
and base address from bootloader. I could just hardcode the values now
that I know them :-)

>
> 	 cont_splash_mem: memory@9c000000 {
> 		reg = <0x0 0x9c000000 0x0 0x2400000>;
> 		no-map;
> 	};
>
> FWIW, example above (with similar simple-framebuffer
> node) worked fine for my sm8150 based device.

Oh okay. So it's likely to be something specific to our bootloader.

-- 
balbi