Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <Yb3AbFhc9ApdHpcA@codewreck.org>
References: <Yb3AbFhc9ApdHpcA@codewreck.org> <20211203185816.796637-1-arnd@kernel.org> <YaqwdNGlZDBDcg5R@codewreck.org>
To:     Dominique Martinet <asmadeus@codewreck.org>
Cc:     dhowells@redhat.com, Arnd Bergmann <arnd@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Eric Van Hensbergen <ericvh@gmail.com>,
        Latchesar Ionkov <lucho@ionkov.net>,
        Jeff Layton <jlayton@kernel.org>,
        v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 9p: fix unused-variable warning
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2222223.1639835496.1@warthog.procyon.org.uk>
Date:   Sat, 18 Dec 2021 13:51:36 +0000
Message-ID: <2222224.1639835496@warthog.procyon.org.uk>
Precedence: bulk

Dominique Martinet <asmadeus@codewreck.org> wrote:

> David since then fixed the warning differently in v2 of the patch (he
> moved the fscache_note_page_release() out of the ifdef), so I won't do
> anything with this even if in principle I tend to agree that
> if(IS_ENABLED()) lead to better compiler coverage

Yeah, fscache_note_page_release() compiles out in such a case because
v9fs_inode_cookie() becomes unconditionally NULL if it's disabled.

If you want me to do something different, can you give me an incremental patch
to merge into mine?

David