Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83534C4332F for ; Sat, 18 Dec 2021 14:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233315AbhLROfL (ORCPT ); Sat, 18 Dec 2021 09:35:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230522AbhLROfH (ORCPT ); Sat, 18 Dec 2021 09:35:07 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77473C06173F for ; Sat, 18 Dec 2021 06:35:07 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id d10so10894223lfg.6 for ; Sat, 18 Dec 2021 06:35:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pYgC6UbioLpLUDdPygjohyGooIms1qIM+qPuyGqET70=; b=rHhgE6Zlotk8HdSmidDY7wBJeHWSp00Vfo+Aqyou5BgyXPRyKu8LnPMUgXmkKkflzx udb3hkJAw6YSaGTz2tvs0AUdbG9qxcputvPHcQJHMxINHngDuOsk5v1e2RDCfUnB1Ab8 Km2eL88kgKvUp1qHFQIF+u/2wiYm+aqXrJo5w5NWU3ewPCL+RZWQvfMM8aVSybzkQWv2 YznjW4G5pZEtM+9rqSNDOTSDoor1uxwRfciKnnPsd/l/oMeQiT+BBMLp7QmdgammQt4/ 5yoUrYl7NRtmvNpp4QCxknwd6fmsh7MmHlYOIuMeHEPl2JNzg5WgzpB/pIaguDzdx6I4 IGyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pYgC6UbioLpLUDdPygjohyGooIms1qIM+qPuyGqET70=; b=78gFZ45Zvn+M/N8zh//Xzs5lecBlRaDEwIHC4AVp1CcbtB2rlbXmArZEQN5GrpzheF i/T+s08uvu7kvUhsyjQTLq/i5018sSnLs5YUqJV8wU0TgAXH5yNN2Hd6r0Mj15gPtkgR RRzvqel7y9cGmt83pM2bIL9PcdVWinTaeYYXBvGbVvoWf0mIWHer1f1mbhxiIhdfTSFO rY56tooNaGDZAbrpqpd1JBQeMZPG25A5DMMbMH0O8lHURx9IrgLj0LQunrZcIJ4jHJRX 7uOPMDeK1XJejjr5dHcNzDRUodwAeok+IHypmfnAcMiFwiuWmXxGGGp3xFkTEU5gX4FN pwaA== X-Gm-Message-State: AOAM530Ac1Bu+ae29+ezHFELVXLKGiwbUZ3vMCmOe/aySReRw2g9JaQR Y1kQI0R5+jSPOvErKVdO2/Bbog== X-Google-Smtp-Source: ABdhPJyJfweji7/uZmtDXAtvhhz48SwfdSecz//NO1/1kZj2ekmyONM2NijthLcvedNhQHMMoHkBbQ== X-Received: by 2002:a05:6512:ac9:: with SMTP id n9mr462354lfu.460.1639838105757; Sat, 18 Dec 2021 06:35:05 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id s4sm1728641lfp.198.2021.12.18.06.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Dec 2021 06:35:05 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 98E2D103A58; Sat, 18 Dec 2021 17:35:12 +0300 (+03) Date: Sat, 18 Dec 2021 17:35:12 +0300 From: "Kirill A. Shutemov" To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, Andrew Morton , Hugh Dickins , Linus Torvalds , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Vlastimil Babka , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v1 04/11] mm: thp: simlify total_mapcount() Message-ID: <20211218143512.luh7jnd4y7it2yun@box.shutemov.name> References: <20211217113049.23850-1-david@redhat.com> <20211217113049.23850-5-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211217113049.23850-5-david@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 17, 2021 at 12:30:42PM +0100, David Hildenbrand wrote: > Let's simplify a bit, returning for PageHuge() early and using > head_compound_page() as we are only getting called for HEAD pages. > > Note the VM_BUG_ON_PAGE(PageTail(page), page) check at the beginning of > total_mapcount(). > > This is a preparation for further changes. > > Reviewed-by: Peter Xu > Signed-off-by: David Hildenbrand Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov