Date:   Sat, 18 Dec 2021 17:52:55 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Yevhen Orlov <yevhen.orlov@plvision.eu>
Cc:     netdev@vger.kernel.org,
        Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        Taras Chornyi <tchornyi@marvell.com>,
        Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/6] prestera: add basic router driver support
Message-ID: <Yb4R55w1mq+NXOwO@lunn.ch>
References: <20211217195440.29838-1-yevhen.orlov@plvision.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211217195440.29838-1-yevhen.orlov@plvision.eu>
Precedence: bulk

On Fri, Dec 17, 2021 at 09:54:32PM +0200, Yevhen Orlov wrote:
> Add initial router support for Marvell Prestera driver.
> Subscribe on inetaddr notifications. TRAP packets, that has to be routed
> (if packet has router's destination MAC address).

I must be missing something here. Why do you need to tell it the IP
address in order to perform software routing? All the switch needs to
know is the MAC address. Any packets for that MAC address should be
trapped to the host. The host can then decide what to do with it,
router, bridge, or consume it itself.

> Add features:
>  - Support ip address adding on port.
>    e.g.: "ip address add PORT 1.1.1.1/24"

This should just work already. If it does not, you have something
wrong in your current support.

	Andrew