Date: Fri, 26 Jan 2007 13:08:01 +0300
From: Oleg Nesterov <oleg@tv-sign.ru>
To: S?bastien Dugu? <sebastien.dugue@bull.net>
Cc: Zach Brown <zach.brown@oracle.com>,
       Suparna Bhattacharya <suparna@in.ibm.com>,
       Benjamin LaHaise <bcrl@kvack.org>, Ulrich Drepper <drepper@redhat.com>,
       Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
       Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: + make-good_sigevent-non-static.patch added to -mm tree
Message-ID: <20070126100801.GA94@tv-sign.ru>
References: <20070125154324.GA183@tv-sign.ru> <20070126103208.78c4937f@frecb000686>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20070126103208.78c4937f@frecb000686>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1518
Lines: 48

On 01/26, S?bastien Dugu? wrote:
>
> On Thu, 25 Jan 2007 18:43:24 +0300 Oleg Nesterov <oleg@tv-sign.ru> wrote:
> 
> > S?bastien Dugu? wrote:
> > >
> > > +struct task_struct *good_sigevent(sigevent_t *event)
> > > +{
> > > +	struct task_struct *task = current->group_leader;
> > > +
> > > +	if ((event->sigev_notify & SIGEV_THREAD_ID) == SIGEV_THREAD_ID) {
> > > +		task = find_task_by_pid(event->sigev_notify_thread_id);
> > > +
> > > +		if (!task || task->tgid != current->tgid)
> > > +			return NULL;
> > > +	} else if (event->sigev_notify == SIGEV_SIGNAL) {
> > 
> > No, no, we can't use "else" here,
> > 
> > > +		if (event->sigev_signo <= 0 || event->sigev_signo > SIGRTMAX)
> > 
> > because we skip the check above in SIGEV_THREAD_ID case.
> 
>   Right, will fix this.
> 
> > 
> > This way any user can crash the kernel with a minimal effort.
> 
>   Well I tried, no crash, just the signal failing to be delivered.

	sigaddset:

		set->sig[sig / _NSIG_BPW] |= 1UL << (sig % _NSIG_BPW);

This writes to ->sig[event->sigev_signo / _NSIG_BPW] location, so we can
corrupt the memory if ->sigev_signo > _NSIG.

Btw, since you are exporting this function, may I suggest to rename it?
No, I can't suggest a better name :) But "good_sigevent" is a bit confusing
imho.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/