Date:   Mon, 20 Dec 2021 00:30:10 +0300
From:   Cyrill Gorcunov <gorcunov@gmail.com>
To:     "Eric W. Biederman" <ebiederm@xmission.com>
Cc:     Barret Rhoden <brho@google.com>,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Alexey Gladkov <legion@kernel.org>,
        William Cohen <wcohen@redhat.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Chris Hyser <chris.hyser@oracle.com>,
        Peter Collingbourne <pcc@google.com>,
        Xiaofeng Cao <caoxiaofeng@yulong.com>,
        David Hildenbrand <david@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rlimits: do not grab tasklist_lock for do_prlimit on
 current
Message-ID: <Yb+kYqLVbL3N9d/4@grain>
References: <20211213220401.1039578-1-brho@google.com>
 <8735mww2w3.fsf@email.froward.int.ebiederm.org>
 <456a056e-453e-71b0-0f9e-03511b9f56b1@google.com>
 <87zgp1psd3.fsf@email.froward.int.ebiederm.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87zgp1psd3.fsf@email.froward.int.ebiederm.org>
User-Agent: Mutt/2.0.7 (2021-05-04)
Precedence: bulk

On Wed, Dec 15, 2021 at 01:42:32PM -0600, Eric W. Biederman wrote:
...
> 
> > If it's too much of a risk/ugliness for not clear enough gain (in code
> > quality or performance), I'm fine with dropping it.
> 
> Removing the tasklist_lock where we can is definitely a clear gain.
> 
> Simply shoving tasklist_lock aside and making the code more complicated
> is much less clear.
> 
> Plus anything you can benchmark (even microbenchmark) and show the
> benefit of is welcome.  Especially when you have indications that it
> makes a difference in a larger context.

Thanks for looking into this, Eric! I must confess I've a vague memory
about this code. Still while you're talking about cleanup I wonder if
we should make do_prlimit() being a static function, not global as it
now.