Date:   Sun, 19 Dec 2021 13:32:57 -0800
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Xiaoming Ni <nixiaoming@huawei.com>
Cc:     linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk,
        ebiederm@xmission.com, keescook@chromium.org, jlayton@kernel.org,
        bfields@fieldses.org, yzaikin@google.com, apw@canonical.com,
        joe@perches.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com,
        julia.lawall@inria.fr, akpm@linux-foundation.org,
        wangle6@huawei.com
Subject: Re: [PATCH v3] sysctl: Add a group of macro functions to initcall
 the sysctl table of each feature
Message-ID: <Yb+lCVrP3eGfKjE+@bombadil.infradead.org>
References: <20211210085849.66169-1-nixiaoming@huawei.com>
 <20211213033119.51263-1-nixiaoming@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211213033119.51263-1-nixiaoming@huawei.com>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Mon, Dec 13, 2021 at 11:31:19AM +0800, Xiaoming Ni wrote:
> To avoid duplicated code, add a set of macro functions to initialize the
> sysctl table for each feature.
> 
> The system initialization process is as follows:

See Eric's comments, we don't need to take care here on order as if the
path does not exist, it will be created. So please updates the commit to
to instead reflect that reality as I was just lazy and assumed the worst
and was just being cautious. If you get to add a few tests on
lib/test_sysctl.c and tools/testing/selftests/sysctl/sysctl.sh  to
verify it would be great too.

  Luis