Message-ID: <81c268df-af27-33b2-5a07-5a559ca0bead@amd.com>
Date:   Mon, 20 Dec 2021 11:53:43 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH v3 0/3] svm: avic: Allow AVIC support on system w/
 physical APIC ID > 255
Content-Language: en-US
To:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org
Cc:     pbonzini@redhat.com, joro@8bytes.org, seanjc@google.com,
        mlevitsk@redhat.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, peterz@infradead.org, hpa@zytor.com,
        thomas.lendacky@amd.com, jon.grimm@amd.com
References: <20211213113110.12143-1-suravee.suthikulpanit@amd.com>
From:   Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
In-Reply-To: <20211213113110.12143-1-suravee.suthikulpanit@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHJUNEN6c3M3QlgxZno2Ly8wVTlhM2ZMRWVSZmhPSFFGaUphNmNibE0xVDFn?=
 =?utf-8?B?SCtFbnd1RFMyV2pOSlBscXp5dis4UTgyakFKM2p4OFE3enVLMTVrbEUwanZ1?=
 =?utf-8?B?bVdqN1A5dDROejdTaGx1SXhmQlQ1bmxUQWx3QitQMU12V1hKQks1dFRMODc4?=
 =?utf-8?B?b3ZxY0tWbVBwazNFcms3eTcwb0pHZGtrd2IwMEVlME5iNFFDMnZqYkZIQVZk?=
 =?utf-8?B?eFJGWStiTk1nR3FiVytMa1JzVmY2ZnF0Tmp6U2hWUGJwbG02dUZWYVRmRWkv?=
 =?utf-8?B?Y3BBelk3WSt6SzhuQkhiV3h5TXJDUGpPQWVPdFZuaG9KY1ZhY09TQ2s3ejFQ?=
 =?utf-8?B?ZGpKN3FqMXdLTi9QN0hSbUJJY3I4azFab29Ed3c3Q1pjL0FNVVAyOXJCWEtR?=
 =?utf-8?B?SFA2U2l2OVB2KzVKKzl1MGR3MzNjRmZQbm9lNVA4eEtHQjIxcGRGR282NVZI?=
 =?utf-8?B?MTVrMEY0ajNqUTZlcDM0WWp4am9aaGJUQzVGclBPVXlHYTJoWGgzMmcrbGJU?=
 =?utf-8?B?TlNVcnFRTnpNSU9oVjRSaDJ1a1JlMXA3VWRiT200ZFRFYy9YNlB6NzFzOGha?=
 =?utf-8?B?VFYySnVIc3hRY0M4TDdNb25oUTJjVVVtSFJ4TmNwaWxDUWZkZis1bU4xU0d4?=
 =?utf-8?B?WGxJL0pNdCtSd29uZENOQ2hEZlcydlFFcitsMTBNQXFwMlJaVi8zb3Via1Mx?=
 =?utf-8?B?NHVyT3kxNGtzZHF0TnFnTyt4RGFQTUpNd1JIa05wT2FUdlZiNHBCbUp3empJ?=
 =?utf-8?B?aEdoRkR0aW55Z0NrKzU2bE9NS2MxMkNOZ3padmhrczFOUmRaQXN3eU02dHBp?=
 =?utf-8?B?ZHpubkxuV0svd09sU2o0aCtsb0p0a2ZQcFMzUkI3TmlUb1JiSXhLNm0zMGZE?=
 =?utf-8?B?VWt4VFdLL0xnZDZ4SmNSRitUZ0Q5WGJBVkQ1L0IxMFc0UDJCV2thU3NkNXNs?=
 =?utf-8?B?VlFuMTB0WXNSU3lNVmJHd3l6a1ZGL1VnSjF6MWN5T2tPS0dKK1lLZUlPZkdu?=
 =?utf-8?B?Zmg0YlpRd0pvK21Dc3JHdzZJd1ZzcFlMdUF3Uld5VmJQdnk4bkZrY2NXN014?=
 =?utf-8?B?L3BCNkgxY0hRN3NReDk1MXQxYTVWeXlab0R0MlNsU0trQWtYU21QTzhyaWxo?=
 =?utf-8?B?aGo2WmZkdlBsRFNwOXBQdU5VcitIVEpGbHVzV2xkNEI0VEV6eWFGUTVQR3Jo?=
 =?utf-8?B?d1RzUW90QStGWmdrQTUrdCtYQ3hQQ1YvVEZwdmlxOGhxeFJ0WlVaSXl5Z09u?=
 =?utf-8?B?c0RPbjgyMEo0V0RwYnZyRUloNDNlZzczQStzekFDMExDcnpGL2tlVFNRaVNV?=
 =?utf-8?B?cVRUY1FFZkZQN3o4V285S1VyRGs1QTlwRkhITG5zUENJaEVUVjd3a3VqUGRi?=
 =?utf-8?B?QjZFcndjaW5lNzE1dWRlWHE5VlU2anVYM2pwemFLWnhYWmdyajJhZjhJK1c1?=
 =?utf-8?B?NncyeEV4NGNONy9jNGRCT0tNbDcra0ZzK3J4OVRjdTZWV1NVY0twVjRPU2lJ?=
 =?utf-8?B?VGpVUXhCamQ3QUdmQ2VQTW5HOGllVkQxalJOMDBmenBVZ2x3NUM0TVRJbHhm?=
 =?utf-8?B?UUN0Szdxc2U1YzVJNVd2VEZZWUJlMDVhenRHcmROQ2lRcmZ1MGNPMTV0K2Zk?=
 =?utf-8?B?U3NGQlkvSVpvWFNPak1tbGE3dDVhS1RpMTdXdGFLU2wzR1JYSEVNYVZoZjY3?=
 =?utf-8?B?QUs0SDU2enZIbEFXRDNWenF6blZRaDV3b1hUS3NnTnlhSURnNERwWG9LVjlB?=
 =?utf-8?B?L2FTSm1IclZMbDRYTDdhODBvRnBVOUJ2TVlncmQ0SXNITm1RSGlVZFA5QzJr?=
 =?utf-8?B?VE1rdk10MVh0QlF5aVM0eDVId2FKazg5Zm9lU3pmMFRuODNma3o4VVFLKzQx?=
 =?utf-8?B?ZGlQcko1ZmFYT1lMU254RnN1WUFIUGJJemdlYy8zSFQ5b01NSUd2NFgzMG12?=
 =?utf-8?B?YnBuVkprSnpvc3pjQ1dwMG1nZkpPN0ZWSklYWTExQi9CT0xacVFtRXZLTjdS?=
 =?utf-8?B?VnFnVTBZKzlrNkNVbTAxT3lscEdtc2U3cDFsUFRBSDluL2UwU21iUUhvODBp?=
 =?utf-8?B?ZXRJOXdGTVhBbm4ycmNjZzY0QU1tVkkzRkFiWGg0SjdpTDcybWlJekV4ZWls?=
 =?utf-8?B?VFRFL1NqVGRFYVp5TDBnU1dVZ3RYVnlmRExFVU0rVDlYd0NEMG04NjlVTnJM?=
 =?utf-8?Q?Gx1m9w0LoXIdsuoQWdIW1DY=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e57482a-9cc4-4dfe-7c9f-08d9c374baee
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2021 04:53:57.3043
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eMV2IZciJtiDRRM5sBcScy1JafBmXyJhNtiUe1Hn1VDduUcguFssoGxh5mRzwEB+t7MvrguVnFy/JA3Eo1teQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5325
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Are there any other concerns with this series?

Regards,
Suravee

On 12/13/21 6:31 PM, Suravee Suthikulpanit wrote:
> Originally, AMD SVM AVIC supports 8-bit host physical APIC ID.
> However, newer AMD systems can have physical APIC ID larger than 255,
> and AVIC hardware has been extended to support upto the maximum physical
> APIC ID available in the system.
> 
> This series introduces a helper function in the APIC subsystem to get
> the maximum physical APIC ID allowing the SVM AVIC driver to calculate
> the number of bits to program the host physical APIC ID in the AVIC
> physical APIC ID table entry.
> 
> Regards,
> Suravee Suthikulpanit
> 
> Changes from V2 (https://www.spinics.net/lists/kvm/msg261351.html)
> 
>   * Use global variable npt_enabled instead (patch 1/3)
> 
>   * Use BIT_ULL() instead of BIT() since avic_host_physical_id_mask
>     is 64-bit value (patch 3/3)
> 
> Suravee Suthikulpanit (3):
>    KVM: SVM: Refactor AVIC hardware setup logic into helper function
>    x86/apic: Add helper function to get maximum physical APIC ID
>    KVM: SVM: Extend host physical APIC ID field to support more than
>      8-bit
> 
>   arch/x86/include/asm/apic.h |  1 +
>   arch/x86/kernel/apic/apic.c |  6 ++++++
>   arch/x86/kvm/svm/avic.c     | 38 +++++++++++++++++++++++++++++--------
>   arch/x86/kvm/svm/svm.c      |  8 +-------
>   arch/x86/kvm/svm/svm.h      |  2 +-
>   5 files changed, 39 insertions(+), 16 deletions(-)
>