IronPort-SDR: KSMuJTqJsp1pIgZMEqcypuAVclu2TmHHJkdUC7xZcDsTHZqNG0+b/Rmpw+gJCHhIE6G0MUuLeB
 coUjTcudZSUtx1MS5BWDNPpaWlgtweHqnkeD7CorBEkN9bKTMc3yQH8pzelxYYRPhls/dWWvx3
 s9L6CoHiws2Hx95uVXCrkCOjNTNGzlccSdckD3FUs0esM0DpI062JN3OD7wOSppbdXy2yIdCP6
 pqAvcmY0ZsIJkLv9bmHx5j2ZEMyI/CcxKMjiVKQh6O5c8UF9RxPlb6wSWjsTkm6JuRdm+Paz8U
 OZ5KXfUrUBHfF7pTvhw69Fz1
From:   <Conor.Dooley@microchip.com>
To:     <broonie@kernel.org>
CC:     <linus.walleij@linaro.org>, <bgolaszewski@baylibre.com>,
        <robh+dt@kernel.org>, <jassisinghbrar@gmail.com>,
        <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
        <aou@eecs.berkeley.edu>, <a.zummo@towertech.it>,
        <alexandre.belloni@bootlin.com>, <gregkh@linuxfoundation.org>,
        <thierry.reding@gmail.com>, <u.kleine-koenig@pengutronix.de>,
        <lee.jones@linaro.org>, <linux-gpio@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-i2c@vger.kernel.org>, <linux-pwm@vger.kernel.org>,
        <linux-riscv@lists.infradead.org>, <linux-crypto@vger.kernel.org>,
        <linux-rtc@vger.kernel.org>, <linux-spi@vger.kernel.org>,
        <linux-usb@vger.kernel.org>, <krzysztof.kozlowski@canonical.com>,
        <geert@linux-m68k.org>, <bin.meng@windriver.com>,
        <heiko@sntech.de>, <Lewis.Hanly@microchip.com>,
        <Daire.McNamara@microchip.com>, <Ivan.Griffin@microchip.com>,
        <atish.patra@wdc.com>
Subject: Re: [PATCH v2 10/17] dt-bindings: spi: add bindings for microchip
 mpfs spi
Thread-Topic: [PATCH v2 10/17] dt-bindings: spi: add bindings for microchip
 mpfs spi
Thread-Index: AQHX8ykv6sbPo1+d0UqqLmeeX2B3NKw2iOgAgAAHFACAAABvgIAEemoA
Date:   Mon, 20 Dec 2021 08:05:13 +0000
Message-ID: <2981d13d-13c7-f455-722e-778fb07f170f@microchip.com>
References: <20211217093325.30612-1-conor.dooley@microchip.com>
 <20211217093325.30612-11-conor.dooley@microchip.com>
 <YbxxrlmYGC3Pg8+j@sirena.org.uk>
 <606633c8-6cd6-af3a-4d6a-bb3058a64026@microchip.com>
 <Ybx3+3QaVe2lCcQP@sirena.org.uk>
In-Reply-To: <Ybx3+3QaVe2lCcQP@sirena.org.uk>
Accept-Language: en-IE, en-US
Content-Language: en-IE
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?sG/Z1ifRiyJgKgg4hkAfwK2/rkoePAu416Z/A9KhbYZvHImDqj5o54Oo?=
 =?Windows-1252?Q?u1FaWVSTgatc4XUz7BTeFv7af3t3A2zL46gCDLM4FIjmT4FzOXx5flvr?=
 =?Windows-1252?Q?WqdGRk/ArmtQsVjSzacDhoBykAD2cMhFJAYEzaoP/LAJaNoE50Sae69m?=
 =?Windows-1252?Q?HVPzbw1qqtdFRKuY/gtQzgZ0YDp44Lx+2m7tAQ6DHzo8xjgBahcTKceo?=
 =?Windows-1252?Q?ovwjg133YruZxKO5qk6yWgszscp+ARa1/1DjXA7wbg29LNW+f+w2/CiH?=
 =?Windows-1252?Q?5lNJEOau3t+X/Jk7q9ID5LIE0bZbO3/A1bMWC4FneMsHz9UF1qT4kE/N?=
 =?Windows-1252?Q?MmJk4lC5002OHPc5DepJiTrC9TAblKCMHrOtZArmbKKjEDd9VUZvSE0M?=
 =?Windows-1252?Q?Tj+GRMMIrGlk9nOYZgLqZf9so7hBhiHTCztbhIWuC3J/Tc+Js8E0QJ5h?=
 =?Windows-1252?Q?O2gMk7KluXFLdC9JWXv8Ckpsu94IS7hoa2PuSC2XdM+Hi5ZOkOXMDpf0?=
 =?Windows-1252?Q?MZSJcgusNTNgIDYHHMNFAxLm12rri0BSnYAl6sFvMTYJZ3FuklzP9y5Q?=
 =?Windows-1252?Q?GU2/Mj1E5iOQJdhJXPWcu0pVEJkAca6cQt4KOC/QdNfMoW+wnkdOEjTY?=
 =?Windows-1252?Q?8r/0miGWZoTo1mssbpBKrS0Ei1gJgKCTBkvNO4SM5UIUhfzvywi81sR/?=
 =?Windows-1252?Q?guwQTAqWW/DDHoktahtnUek4wlz6H2d5RtejNLOkbwvYjjPiBfAyEy1/?=
 =?Windows-1252?Q?vPRPAppj/1ORh9SjetU9PHSjAUNFgHlptXVO92oUt4hUgHAtWq4gp+Bu?=
 =?Windows-1252?Q?EcAzkR4JytciPF7rhlc4yRli5zfi2kMj1qH+xGT5kuUVnbZqdIcOzv1y?=
 =?Windows-1252?Q?P6pG+oqGDbsUJSlwjyk9aMW2WbOhLNCzVrFtEKlbNs3bhP4vpreeJz64?=
 =?Windows-1252?Q?OO9UDl/VV3UFWKKS/Xf4dUUNF/66oBOI9pSgyiAxuEdO6EMRYe83rRPd?=
 =?Windows-1252?Q?MnsH7pkf/EyAkOAkycSZZFx/dl2hLILLc81JNA+b9SsDRJVYxQOd+zRe?=
 =?Windows-1252?Q?ppF/UsZ7iOkBpBylkjzWoJqj5eeJIN6zgy3lM+bwDirNQ/fUDbH7MRM1?=
 =?Windows-1252?Q?LIFicjb+szHu1zb3CDOxI23WgKlRSUSMHcrozcvomp/YbMF/dw5vHsxt?=
 =?Windows-1252?Q?s5zB82whQavx3whZMQy5GX+bCSek7etM+Nd0lNmwjZc3hZ9c1k0u1OFT?=
 =?Windows-1252?Q?kKCey3o8LlpIJzxoNqLG+WF7LMjcuIjY9g65Y6fYbeaJriizcJg/Dai9?=
 =?Windows-1252?Q?xyglk1rFa+3pbWWszBsTrPNitS7ec5XLEN5Vnn9z4VSeSt0qgQ0dHXAt?=
 =?Windows-1252?Q?nNXAIKAR6qgzxq2rWVLXvz4Kc/PIXyFSNwfhT/6XTPpETVH2IKNjwoNi?=
 =?Windows-1252?Q?Y7vh6HKraG6V+TWwW5Rq0MWdBePrOhoQfCElUmbL5AVzcoB25jN4CIxt?=
 =?Windows-1252?Q?ox8q2FHJcYmHJfQNiwBT/u3m4ivwtJuYEW+Ypij+pVNygn4tdgtBKnOy?=
 =?Windows-1252?Q?648LE5N8ndnrj+1sFs6ejbylpFr/JMAcaHtHIVh2iKn29WYe9u48kane?=
 =?Windows-1252?Q?oIByX0JNyX4kKKtO5CNdhWH13E+qsrbZQytu8mvfL0HvJU720ICg2/FZ?=
 =?Windows-1252?Q?WEwGHPhBQ/eeOuP4lYNuP7QlyNSfFQUoI26Ju5pxepnIE+h2pRkLGGQl?=
 =?Windows-1252?Q?Or8XV53HUDvOPs9yWoFKhcxyabfDfQENHy8mXAjZ0uswNx+FkVxjJCEf?=
 =?Windows-1252?Q?h/jKDg=3D=3D?=
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <4719C4EB9F0F6741A01BFF335C8421B5@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5154.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ea58834-ac3c-463a-7c6c-08d9c38f7354
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2021 08:05:13.0886
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 16SjlWGnaSDKE6kgLOsZLyD145gznsFZvjHMH92lODt08IYgDdGm3P1nBhZiAGXBzLROVlxRricbce/ghNh0bIi1etoqC0U8vlVA2vDRMRs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4634
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 17/12/2021 11:43, Mark Brown wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you=20
know the content is safe
>
> On Fri, Dec 17, 2021 at 11:40:29AM +0000, Conor.Dooley@microchip.com=20
wrote:
>> On 17/12/2021 11:17, Mark Brown wrote:
>>> Why do you need this property in the DT - isn't the number of chip
>>> selects in the IP a fixes property?
>>
>> Nope! It's an IP that's intended for use in FPGAs so the number of
>> selects may (and does) vary based on implementation.
>
> That doesn't explain why the number is needed in the binding - why do
> you need this property in the DT?

Took another look at the IP core configuration & I think you're right=20
and that property can be dropped. The register responsible for CS=20
control will not be optimised away even if the CS is not used & the=20
worst outcome is that nothing will happen.