Subject: Re: [PATCH v2][RFC 1/2] Implement Ziegler-Nichols Heuristic
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org,
        rui.zhang@intel.com, linux-pm@vger.kernel.org,
        Chetankumar Mistry <chetan.mistry@arm.com>,
        linux-kernel@vger.kernel.org
References: <20211217184907.2103677-1-chetan.mistry@arm.com>
 <28c7a12e-6d85-d15d-8884-997eb68612e9@infradead.org>
From:   Lukasz Luba <lukasz.luba@arm.com>
Message-ID: <a78792dd-f755-59c1-57e5-a9ea9cc18d7f@arm.com>
Date:   Mon, 20 Dec 2021 09:58:55 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <28c7a12e-6d85-d15d-8884-997eb68612e9@infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Randy,

Chetan is on holidays and I'll respond to feedback.

On 12/18/21 6:07 AM, Randy Dunlap wrote:
> 
> 
> On 12/17/21 10:49, Chetankumar Mistry wrote:
>> Implement the Ziegler-Nichols Heuristic algorithm to better
>> estimate the PID Coefficients for a running platform.
>> The values are tuned to minimuse the amount of overshoot in
>> the temperature of the platform and subsequently minimise
>> the number of switches for cdev states.
>>
>> Signed-off-by: Chetankumar Mistry <chetan.mistry@arm.com>
> 
> The kernel-doc changes all look good and don't cause any warnings.
> Thanks.

Thank you for the testing it.

Regards,
Lukasz