Message-ID: <90352f48-86a8-f8d9-2b74-b884b32d013d@linux.intel.com>
Date:   Mon, 20 Dec 2021 13:37:48 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v12 01/16] perf record: Introduce thread affinity and mmap
 masks
Content-Language: en-GB
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Alexander Antonov <alexander.antonov@linux.intel.com>,
        Alexei Budankov <abudankov@huawei.com>,
        Riccardo Mancini <rickyman7@gmail.com>
References: <cover.1637675515.git.alexey.v.bayduraev@linux.intel.com>
 <22ee51ee5430b51eee5f03301fb498d5d3e33d1e.1637675515.git.alexey.v.bayduraev@linux.intel.com>
 <YazXMuT+oQ9cFeTi@krava>
From:   "Bayduraev, Alexey V" <alexey.v.bayduraev@linux.intel.com>
Organization: Intel Corporation
In-Reply-To: <YazXMuT+oQ9cFeTi@krava>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 05.12.2021 18:13, Jiri Olsa wrote:
> On Tue, Nov 23, 2021 at 05:07:57PM +0300, Alexey Bayduraev wrote:
> 
> SNIP
> 
>> +static void record__mmap_cpu_mask_init(struct mmap_cpu_mask *mask, struct perf_cpu_map *cpus)
>> +{
>> +	int c;
>> +
>> +	for (c = 0; c < cpus->nr; c++)
>> +		set_bit(cpus->map[c], mask->bits);
>> +}
>> +
>> +static void record__free_thread_masks(struct record *rec, int nr_threads)
>> +{
>> +	int t;
>> +
>> +	if (rec->thread_masks)
>> +		for (t = 0; t < nr_threads; t++)
>> +			record__thread_mask_free(&rec->thread_masks[t]);
>> +
>> +	zfree(&rec->thread_masks);
>> +}
>> +
>> +static int record__alloc_thread_masks(struct record *rec, int nr_threads, int nr_bits)
>> +{
>> +	int t, ret;
>> +
>> +	rec->thread_masks = zalloc(nr_threads * sizeof(*(rec->thread_masks)));
>> +	if (!rec->thread_masks) {
>> +		pr_err("Failed to allocate thread masks\n");
>> +		return -ENOMEM;
>> +	}
>> +
>> +	for (t = 0; t < nr_threads; t++) {
>> +		ret = record__thread_mask_alloc(&rec->thread_masks[t], nr_bits);
>> +		if (ret)
>> +			goto out_free;
>> +		record__thread_mask_clear(&rec->thread_masks[t]);
> 
> nit, is this clear needed?

Hi,

You are right, since all elements of mask->bits is set to zero after
bitmap_zalloc in record__thread_mask_alloc, calling
record__thread_mask_clear after record__thread_mask_alloc
is redundant.
I will remove it here and in [PATCH v12 13/16].

Thanks,
Alexey

> 
> jirka
> 
>> +	}
>> +
>> +	return 0;
>> +
>> +out_free:
>> +	record__free_thread_masks(rec, nr_threads);
>> +
>> +	return ret;
>> +}
>> +
> 
> SNIP
>