Date:   Mon, 20 Dec 2021 13:14:36 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Sergey Shtylyov <s.shtylyov@omp.ru>
Cc:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, agross@kernel.org,
        bjorn.andersson@linaro.org, balbi@kernel.org,
        p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: qcom: Check for null irq pointer
Message-ID: <YcBzrN2Y7++Iephs@kroah.com>
References: <20211220101520.930658-1-jiasheng@iscas.ac.cn>
 <d7974f16-74b1-4d8a-2c28-8acb710d6310@omp.ru>
 <4dcc204a-ba68-ebb8-021d-fd4b54be2729@omp.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4dcc204a-ba68-ebb8-021d-fd4b54be2729@omp.ru>
Precedence: bulk

On Mon, Dec 20, 2021 at 02:48:12PM +0300, Sergey Shtylyov wrote:
> On 20.12.2021 14:25, Sergey Shtylyov wrote:
> 
> > > The return value of platform_get_irq() needs to be checked.
> > > To avoid use of null pointer
> > 
> >  ? What null pointer, could you please clarify?
> > 
> > > in case that there is no irq.
> > > 
> > > Fixes: 2bc02355f8ba ("usb: dwc3: qcom: Add support for booting with ACPI")
> > > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> 
>    This has already been addressed by this (yet unmerged) patch:
> 
> https://marc.info/?l=linux-usb&m=162854066430255

Why not wait until that patch is actually merged?  Otherwise all of this
work is moot.

greg k-h