Message-ID: <3da4130b-4412-6ae7-11ee-00245a02286a@omp.ru>
Date:   Mon, 20 Dec 2021 15:22:47 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] usb: dwc3: qcom: Check for null irq pointer
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, <agross@kernel.org>,
        <bjorn.andersson@linaro.org>, <balbi@kernel.org>,
        <p.zabel@pengutronix.de>, <linux-arm-msm@vger.kernel.org>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20211220101520.930658-1-jiasheng@iscas.ac.cn>
 <d7974f16-74b1-4d8a-2c28-8acb710d6310@omp.ru>
 <4dcc204a-ba68-ebb8-021d-fd4b54be2729@omp.ru> <YcBzrN2Y7++Iephs@kroah.com>
From:   Sergey Shtylyov <s.shtylyov@omp.ru>
Organization: Open Mobile Platform
In-Reply-To: <YcBzrN2Y7++Iephs@kroah.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 20.12.2021 15:14, Greg KH wrote:

[...]
>>>> The return value of platform_get_irq() needs to be checked.
>>>> To avoid use of null pointer
>>>
>>>     What null pointer, could you please clarify?
>>>
>>>> in case that there is no irq.
>>>>
>>>> Fixes: 2bc02355f8ba ("usb: dwc3: qcom: Add support for booting with ACPI")
>>>> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
>>
>>     This has already been addressed by this (yet unmerged) patch:
>>
>> https://marc.info/?l=linux-usb&m=162854066430255

> Why not wait until that patch is actually merged?  Otherwise all of this
> work is moot.

    Wait, it has been merged back in August. Then this patch is just 
outdated... :-)

> greg k-h

MBR, Sergey