Message-ID: <39d259cf-5663-5073-f16b-71a21f0e62e3@quicinc.com>
Date:   Mon, 20 Dec 2021 17:54:42 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] dt-bindings: qcom,pdc: convert to YAML
To:     Luca Weiss <luca.weiss@fairphone.com>,
        <linux-arm-msm@vger.kernel.org>
CC:     <~postmarketos/upstreaming@lists.sr.ht>,
        <phone-devel@vger.kernel.org>, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        "Rob Herring" <robh+dt@kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
References: <20211213152208.290923-1-luca.weiss@fairphone.com>
From:   Maulik Shah <quic_mkshah@quicinc.com>
In-Reply-To: <20211213152208.290923-1-luca.weiss@fairphone.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Luca,

On 12/13/2021 8:52 PM, Luca Weiss wrote:
> Convert the PDC interrupt controller bindings to YAML.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> This patch depends on the following patch, which fixed sm8250 & sm8350
> compatibles and adds sm6350.
> https://lore.kernel.org/linux-arm-msm/20211213082614.22651-4-luca.weiss@fairphone.com/
>
> Also, if somebody has a better suggestion for the register names,
> the second one is pulled from downstream commit message which calls it
> both "SPI config registers" and "interface registers":
> https://source.codeaurora.org/quic/la/kernel/msm-4.19/commit/?id=cdefb63745e051a5bcf69663ac9d084d7da1eeec

Thanks for the patch. Please use "apss-shared-spi-cfg" name for the 
second reg.

It was intended in [1] to remove it since there are no user in upstream 
for second reg. but it should be fine to convert existing to yaml first 
and then look to fix that.

[1] 
https://patchwork.kernel.org/project/linux-arm-msm/list/?series=449725&state=%2A&archive=both

[2] 
https://patchwork.kernel.org/project/linux-arm-msm/patch/1616409015-27682-1-git-send-email-mkshah@codeaurora.org/

Thanks,
Maulik
>
>   .../interrupt-controller/qcom,pdc.txt         | 77 -----------------
>   .../interrupt-controller/qcom,pdc.yaml        | 86 +++++++++++++++++++
>   2 files changed, 86 insertions(+), 77 deletions(-)
>   delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
>   create mode 100644 Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
>