Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <e20f590b-b9d9-237d-3b9c-77dd82a24b40@redhat.com>
Date:   Mon, 20 Dec 2021 14:19:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH v2 19/23] kvm: selftests: Add support for KVM_CAP_XSAVE2
Content-Language: en-US
To:     Jing Liu <jing2.liu@intel.com>, x86@kernel.org,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com
Cc:     seanjc@google.com, jun.nakajima@intel.com, kevin.tian@intel.com,
        jing2.liu@linux.intel.com, guang.zeng@intel.com,
        wei.w.wang@intel.com, yang.zhong@intel.com
References: <20211217153003.1719189-1-jing2.liu@intel.com>
 <20211217153003.1719189-20-jing2.liu@intel.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <20211217153003.1719189-20-jing2.liu@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/17/21 16:29, Jing Liu wrote:
> @@ -370,6 +397,10 @@ struct kvm_vm *vm_create_with_vcpus(enum vm_guest_mode mode, uint32_t nr_vcpus,
>   #ifdef __x86_64__
>   	vm_create_irqchip(vm);
>   #endif
> +	/*
> +	 * Permission needs to be requested before KVM_SET_CPUID2.
> +	 */
> +	vm_xsave_req_perm();
>   
>   	for (i = 0; i < nr_vcpus; ++i) {
>   		uint32_t vcpuid = vcpuids ? vcpuids[i] : i;

I don't think it's necessary to enable this unconditionally?

Paolo