MIME-Version: 1.0
References: <d4a00def-7765-e0e4-c5c7-8d648eeb8cf2@omp.ru> <20211214140607.1147976-1-nikita.yoush@cogentembedded.com>
In-Reply-To: <20211214140607.1147976-1-nikita.yoush@cogentembedded.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 20 Dec 2021 15:21:14 +0100
Message-ID: <CAMuHMdW=MytCOsghcH9p1GXOPCO3=1mSF8PKj_UAjYEqAq4-1Q@mail.gmail.com>
Subject: Re: [PATCH v2] arm64: dts: renesas: r8a77961: Add lvds0 device node
To:     Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc:     Magnus Damm <magnus.damm@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Sergey Shtylyov <s.shtylyov@omp.ru>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Nikita,

On Tue, Dec 14, 2021 at 3:06 PM Nikita Yushchenko
<nikita.yoush@cogentembedded.com> wrote:
> Add the missing lvds0 node for the R-Car M3-W+ SoC.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> @@ -2718,6 +2718,33 @@ du_out_hdmi0: endpoint {
>                                 port@2 {
>                                         reg = <2>;
>                                         du_out_lvds0: endpoint {
> +                                               remote-endpoint = <&lvds0_in>;
> +                                       };
> +                               };
> +                       };
> +               };
> +
> +               lvds0: lvds@feb90000 {
> +                       compatible = "renesas,r8a7796-lvds";

This should be "renesas,r8a77961-lvds".
To handle that, both the DT bindings[1] and the driver[2] should
be updated.

[1] Documentation/devicetree/bindings/display/bridge/renesas,lvds.yaml
[2] drivers/gpu/drm/rcar-du/rcar_lvds.c

> +                       reg = <0 0xfeb90000 0 0x14>;
> +                       clocks = <&cpg CPG_MOD 727>;
> +                       power-domains = <&sysc R8A77961_PD_ALWAYS_ON>;
> +                       resets = <&cpg 727>;
> +                       status = "disabled";
> +
> +                       ports {
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +
> +                               port@0 {
> +                                       reg = <0>;
> +                                       lvds0_in: endpoint {
> +                                               remote-endpoint = <&du_out_lvds0>;
> +                                       };
> +                               };
> +                               port@1 {
> +                                       reg = <1>;
> +                                       lvds0_out: endpoint {
>                                         };
>                                 };
>                         };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds