Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7E94C433EF for ; Mon, 20 Dec 2021 15:15:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235919AbhLTPPi (ORCPT ); Mon, 20 Dec 2021 10:15:38 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:35118 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239615AbhLTPNs (ORCPT ); Mon, 20 Dec 2021 10:13:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=RyB3+kF9jgGQv01+nZFU/Byy+c41V2RXJGRIwmyYPyw=; b=MTcAeLiJpPgyRUAU26XPT5nLtO +af6aTW7j+l+F+cj4m47z/FOpo1AxocK5bA3SkkF7nOAOfGiyl1xaAKW0ufSuqYZlOK0dawule1xL 2M/TO3QYhWLz4gPS5ax/JWUSyWjWzgMvbj78GnSMNC/3BTfX0gT+1wm6ZZkXxcaRNSec=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mzKMD-00H3a5-UP; Mon, 20 Dec 2021 16:13:45 +0100 Date: Mon, 20 Dec 2021 16:13:45 +0100 From: Andrew Lunn To: "Ismail, Mohammad Athari" Cc: Oleksij Rempel , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Voon, Weifeng" , "Wong, Vee Khee" Subject: Re: [BUG] net: phy: genphy_loopback: add link speed configuration Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 20, 2021 at 11:11:32AM +0000, Ismail, Mohammad Athari wrote: > Hi Andrew, > > As the current genphy_loopback() is not applicable for Marvell > 88E1510 PHY, should we implement Marvell specific PHY loopback > function as below? Yes, that is probably a good solution. We will have to see if other PHY drivers need this as well. If they do, we might move this simple implementation into the core. But for the moment, it can be in the Marvell driver. Andrew