Subject: Re: [PATCH] paride: fix up build warning on mips platforms
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>, tim@cyberelk.net
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211130084626.3215987-1-gregkh@linuxfoundation.org>
 <YcCo8+jTG3b+5GTA@kroah.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <4915ba81-28b1-6008-62f2-50316177fd46@kernel.dk>
Date:   Mon, 20 Dec 2021 09:33:12 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YcCo8+jTG3b+5GTA@kroah.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/20/21 9:01 AM, Greg Kroah-Hartman wrote:
> On Tue, Nov 30, 2021 at 09:46:26AM +0100, Greg Kroah-Hartman wrote:
>> MIPS include files define "PC" so when building the paride driver the
>> following build warning shows up:
>>
>> 	rivers/block/paride/bpck.c:32: warning: "PC" redefined
>>
>> Fix this by undefining PC before redefining it as is done for other
>> defines in this driver.
>>
>> Cc: Tim Waugh <tim@cyberelk.net>
>> Cc: Jens Axboe <axboe@kernel.dk>
>> Cc: linux-block@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> ---
>>  drivers/block/paride/bpck.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/block/paride/bpck.c b/drivers/block/paride/bpck.c
>> index f5f63ca2889d..d880a9465e9b 100644
>> --- a/drivers/block/paride/bpck.c
>> +++ b/drivers/block/paride/bpck.c
>> @@ -28,6 +28,7 @@
>>  
>>  #undef r2
>>  #undef w2
>> +#undef PC
>>  
>>  #define PC			pi->private
>>  #define r2()			(PC=(in_p(2) & 0xff))
>> -- 
>> 2.34.1
>>
> 
> Given the lack of objections to this, I'll just take it through one of
> my trees for 5.17-rc1.

Sorry about that, got lost. I can queue it  up too, or you can add my
acked-by, either is fine.

-- 
Jens Axboe