Subject: Re: Aw: [PATCH v3] mfd: rk808: add reboot support to rk808.c
To:     Frank Wunderlich <frank-w@public-files.de>,
        Peter Geis <pgwipeout@gmail.com>
Cc:     Lee Jones <lee.jones@linaro.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Heiko Stuebner <heiko@sntech.de>,
        linux-rockchip@lists.infradead.org,
        Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
        linux-kernel@vger.kernel.org
References: <20211220144654.926112-1-pgwipeout@gmail.com>
 <trinity-c54ecce4-7a39-4143-b136-f53c9b40ffd1-1640018026851@3c-app-gmx-bap45>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <b0d0e2ff-4282-f104-b8f5-554b059200c9@gmail.com>
Date:   Mon, 20 Dec 2021 19:36:53 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <trinity-c54ecce4-7a39-4143-b136-f53c9b40ffd1-1640018026851@3c-app-gmx-bap45>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

20.12.2021 19:33, Frank Wunderlich пишет:
> Hi
> 
>> Gesendet: Montag, 20. Dezember 2021 um 15:46 Uhr
>> Von: "Peter Geis" <pgwipeout@gmail.com>
>> @@ -749,6 +791,9 @@ static int rk808_remove(struct i2c_client *client)
>>  	if (pm_power_off == rk808_pm_power_off)
>>  		pm_power_off = NULL;
>>
>> +	if (of_property_read_bool(np, "rockchip,system-power-controller"))
>> +		unregister_restart_handler(&rk808_restart_handler);
>> +
>>  	return 0;
>>  }
> 
> this change misses a declaration
> 
> struct device_node *np = client->dev.of_node;

Good catch, technically the whole of_property_read_bool() could be
dropped from rk808_remove() since unregister_restart_handler() survives
if handler wasn't registered.