MIME-Version: 1.0
References: <aced20a94bf04159a139f0846e41d38a1537debb.1640018297.git.andreyknvl@google.com>
In-Reply-To: <aced20a94bf04159a139f0846e41d38a1537debb.1640018297.git.andreyknvl@google.com>
From:   Marco Elver <elver@google.com>
Date:   Mon, 20 Dec 2021 18:08:40 +0100
Message-ID: <CANpmjNP_ctXe8hZz0K2AHdSGsxr7OEYGXsdT5exk3mifHXzCmg@mail.gmail.com>
Subject: Re: [PATCH] lib/test_meminit: destroy cache in kmem_cache_alloc_bulk()
 test
To:     andrey.konovalov@linux.dev
Cc:     Alexander Potapenko <glider@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        kasan-dev@googlegroups.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Andrey Konovalov <andreyknvl@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 20 Dec 2021 at 17:39, <andrey.konovalov@linux.dev> wrote:
>
> From: Andrey Konovalov <andreyknvl@google.com>
>
> Make do_kmem_cache_size_bulk() destroy the cache it creates.
>
> Fixes: 03a9349ac0e0 ("lib/test_meminit: add a kmem_cache_alloc_bulk() test")
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>

Reviewed-by: Marco Elver <elver@google.com>


> ---
>  lib/test_meminit.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/test_meminit.c b/lib/test_meminit.c
> index e4f706a404b3..3ca717f11397 100644
> --- a/lib/test_meminit.c
> +++ b/lib/test_meminit.c
> @@ -337,6 +337,7 @@ static int __init do_kmem_cache_size_bulk(int size, int *total_failures)
>                 if (num)
>                         kmem_cache_free_bulk(c, num, objects);
>         }
> +       kmem_cache_destroy(c);
>         *total_failures += fail;
>         return 1;
>  }
> --
> 2.25.1
>