Sender: Guenter Roeck <groeck7@gmail.com>
Subject: Re: [PATCH] watchdog: s3c2410: Fix getting the optional clock
To:     Sam Protsenko <semen.protsenko@linaro.org>
Cc:     Dan Carpenter <dan.carpenter@oracle.com>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        linux-watchdog@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211212170247.30646-1-semen.protsenko@linaro.org>
 <b618ff5b-ee41-2c29-5074-24fd4d0f0933@canonical.com>
 <CAPLW+4=wcWv4P_M8kQDjB=QfT5N+mFKm0mUdSDjGSgLg=pRGSw@mail.gmail.com>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <4ad8719c-1476-3226-e426-a171b46ca568@roeck-us.net>
Date:   Mon, 20 Dec 2021 13:08:11 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAPLW+4=wcWv4P_M8kQDjB=QfT5N+mFKm0mUdSDjGSgLg=pRGSw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/20/21 7:15 AM, Sam Protsenko wrote:
> On Sun, 12 Dec 2021 at 19:50, Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> On 12/12/2021 18:02, Sam Protsenko wrote:
>>> "watchdog_src" clock is optional and may not be present for some SoCs
>>> supported by this driver. Nevertheless, in case the clock is provided
>>> but some error happens during its getting, that error should be handled
>>> properly. Use devm_clk_get_optional() API for that. Also report possible
>>> errors using dev_err_probe() to handle properly -EPROBE_DEFER error (if
>>> clock provider is not ready by the time WDT probe function is executed).
>>>
>>> Fixes: a4f3dc8d5fbc ("watchdog: s3c2410: Support separate source clock")
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>>> Suggested-by: Guenter Roeck <linux@roeck-us.net>
>>> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
>>> ---
>>>   drivers/watchdog/s3c2410_wdt.c | 22 ++++++++++++----------
>>>   1 file changed, 12 insertions(+), 10 deletions(-)
>>>
>>
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>
> 
> Hi Guenter,
> 
> If there are no outstanding concerns, can you please apply this one?
> Would be nice to see it in v5.17 if that's possible.
> 

I added the patch to my watchdog-next tree, but Wim handles all pull
requests.

Thanks,
Guenter